feat(avm): poseidon2 in vm2 by IlyasRidhuan · Pull Request #11597 · AztecProtocol/aztec-packages

IlyasRidhuan · 2025-01-29T16:45:32Z

Please read contributing guidelines and remove this line.

IlyasRidhuan · 2025-01-29T16:46:03Z

feat(avm): poseidon2 in vm2 #11597 👈 (View in Graphite)
feat(avm): constrained ec_add #11525
feat(avm): constrain sha256 #11048
fix: hardcode value in constants #11442
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

fcarreiro

Will leave some more useful comments tomorrow!

barretenberg/cpp/pil/vm2/ecc.pil

barretenberg/cpp/pil/vm2/poseidon2_hash.pil

fcarreiro · 2025-02-12T17:45:20Z

barretenberg/cpp/pil/vm2/poseidon2_params.pil

+// Alpha (exponentiation): 5
+namespace poseidon2_params;
+    // Internal Matrix Diagonal (for partial rounds)
+    pol MU_0 = 7626475329478847982857743246276194948757851985510858890691733676098590062311;


I think Jean was suggesting we put these (well, for ECC) in the aztec constants so that you can use them both in PIL and C++? no strong preference from my side but worth considering

hmm i think this is fine as is. They're already available in cpp through bb in nicer hex form anyways, while in PIL they need to be in this decimal format.

barretenberg/cpp/src/barretenberg/crypto/poseidon2/poseidon2.test.cpp

barretenberg/cpp/src/barretenberg/vm2/tracegen/poseidon2_trace.cpp

barretenberg/cpp/src/barretenberg/vm2/simulation/poseidon2.hpp

yarn-project/end-to-end/src/web/main.js.LICENSE.txt

barretenberg/cpp/src/barretenberg/vm2/tracegen_helper.cpp

fcarreiro

Looking good in general! Leaving the constraints to Jean.

fcarreiro · 2025-02-13T17:01:07Z

barretenberg/cpp/src/barretenberg/vm2/simulation/execution.cpp

 }

-} // namespace bb::avm2::simulation
+} // namespace bb::avm2::simulation


[Re: line +181]

nit: revert?

See this comment inline on Graphite.

fcarreiro · 2025-02-13T17:05:12Z

barretenberg/cpp/src/barretenberg/vm2/simulation/poseidon2.test.cpp

+
+    std::vector<Poseidon2PermutationEvent> event_results = perm_event_emitter.dump_events();
+
+    EXPECT_EQ(result, expected);


You should still use a container matcher. If you want to reuse your expected variable, you can use ElementsAreArray(). Same in the other EXPECT_EQ against expected. (and in other tests).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.77.0</summary> ## [0.77.0](aztec-package-v0.76.4...aztec-package-v0.77.0) (2025-02-14) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.77.0</summary> ## [0.77.0](barretenberg.js-v0.76.4...barretenberg.js-v0.77.0) (2025-02-14) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.77.0</summary> ## [0.77.0](aztec-packages-v0.76.4...aztec-packages-v0.77.0) (2025-02-14) ### ⚠ BREAKING CHANGES * Only decrement the counter of an array if its address has not changed (noir-lang/noir#7297) ### Features * PIL relations modifications for bc decomposition ([#11935](#11935)) ([6c93058](6c93058)) * Poseidon2 in vm2 ([#11597](#11597)) ([2c199d8](2c199d8)) * Refactor `append_tx_effects_for_blob` ([#11805](#11805)) ([e5a055b](e5a055b)) ### Bug Fixes * **docs:** Update token bridge diagram ([#11982](#11982)) ([e5da9ed](e5da9ed)) * Let LSP read `noirfmt.toml` for formatting files (noir-lang/noir#7355) ([4d35d2f](4d35d2f)) * Only decrement the counter of an array if its address has not changed (noir-lang/noir#7297) ([4d35d2f](4d35d2f)) * Test more prover agents devnet ([#11990](#11990)) ([f12be5f](f12be5f)) ### Miscellaneous * Avoid u128s in brillig memory (noir-lang/noir#7363) ([4d35d2f](4d35d2f)) * **ci:** Downgrade 4epochs test to transfer test ([#11983](#11983)) ([2340aab](2340aab)) * Explanations about skippable ([#11984](#11984)) ([19589bc](19589bc)) * Op wires index from 0 ([#11986](#11986)) ([be1b563](be1b563)) * Prep for ci3 ([8edee9e](8edee9e)) * Remove browser test ([3e570be](3e570be)) * Replace relative paths to noir-protocol-circuits ([b8ba716](b8ba716)) * Some polishing on the skippable document ([#11997](#11997)) ([50e0a38](50e0a38)) * Update docs about integer overflows (noir-lang/noir#7370) ([4d35d2f](4d35d2f)) </details> <details><summary>barretenberg: 0.77.0</summary> ## [0.77.0](barretenberg-v0.76.4...barretenberg-v0.77.0) (2025-02-14) ### Features * PIL relations modifications for bc decomposition ([#11935](#11935)) ([6c93058](6c93058)) * Poseidon2 in vm2 ([#11597](#11597)) ([2c199d8](2c199d8)) ### Miscellaneous * Explanations about skippable ([#11984](#11984)) ([19589bc](19589bc)) * Op wires index from 0 ([#11986](#11986)) ([be1b563](be1b563)) * Some polishing on the skippable document ([#11997](#11997)) ([50e0a38](50e0a38)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.77.0</summary> ## [0.77.0](AztecProtocol/aztec-packages@aztec-package-v0.76.4...aztec-package-v0.77.0) (2025-02-14) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.77.0</summary> ## [0.77.0](AztecProtocol/aztec-packages@barretenberg.js-v0.76.4...barretenberg.js-v0.77.0) (2025-02-14) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.77.0</summary> ## [0.77.0](AztecProtocol/aztec-packages@aztec-packages-v0.76.4...aztec-packages-v0.77.0) (2025-02-14) ### ⚠ BREAKING CHANGES * Only decrement the counter of an array if its address has not changed (noir-lang/noir#7297) ### Features * PIL relations modifications for bc decomposition ([#11935](AztecProtocol/aztec-packages#11935)) ([6c93058](AztecProtocol/aztec-packages@6c93058)) * Poseidon2 in vm2 ([#11597](AztecProtocol/aztec-packages#11597)) ([2c199d8](AztecProtocol/aztec-packages@2c199d8)) * Refactor `append_tx_effects_for_blob` ([#11805](AztecProtocol/aztec-packages#11805)) ([e5a055b](AztecProtocol/aztec-packages@e5a055b)) ### Bug Fixes * **docs:** Update token bridge diagram ([#11982](AztecProtocol/aztec-packages#11982)) ([e5da9ed](AztecProtocol/aztec-packages@e5da9ed)) * Let LSP read `noirfmt.toml` for formatting files (noir-lang/noir#7355) ([4d35d2f](AztecProtocol/aztec-packages@4d35d2f)) * Only decrement the counter of an array if its address has not changed (noir-lang/noir#7297) ([4d35d2f](AztecProtocol/aztec-packages@4d35d2f)) * Test more prover agents devnet ([#11990](AztecProtocol/aztec-packages#11990)) ([f12be5f](AztecProtocol/aztec-packages@f12be5f)) ### Miscellaneous * Avoid u128s in brillig memory (noir-lang/noir#7363) ([4d35d2f](AztecProtocol/aztec-packages@4d35d2f)) * **ci:** Downgrade 4epochs test to transfer test ([#11983](AztecProtocol/aztec-packages#11983)) ([2340aab](AztecProtocol/aztec-packages@2340aab)) * Explanations about skippable ([#11984](AztecProtocol/aztec-packages#11984)) ([19589bc](AztecProtocol/aztec-packages@19589bc)) * Op wires index from 0 ([#11986](AztecProtocol/aztec-packages#11986)) ([be1b563](AztecProtocol/aztec-packages@be1b563)) * Prep for ci3 ([8edee9e](AztecProtocol/aztec-packages@8edee9e)) * Remove browser test ([3e570be](AztecProtocol/aztec-packages@3e570be)) * Replace relative paths to noir-protocol-circuits ([b8ba716](AztecProtocol/aztec-packages@b8ba716)) * Some polishing on the skippable document ([#11997](AztecProtocol/aztec-packages#11997)) ([50e0a38](AztecProtocol/aztec-packages@50e0a38)) * Update docs about integer overflows (noir-lang/noir#7370) ([4d35d2f](AztecProtocol/aztec-packages@4d35d2f)) </details> <details><summary>barretenberg: 0.77.0</summary> ## [0.77.0](AztecProtocol/aztec-packages@barretenberg-v0.76.4...barretenberg-v0.77.0) (2025-02-14) ### Features * PIL relations modifications for bc decomposition ([#11935](AztecProtocol/aztec-packages#11935)) ([6c93058](AztecProtocol/aztec-packages@6c93058)) * Poseidon2 in vm2 ([#11597](AztecProtocol/aztec-packages#11597)) ([2c199d8](AztecProtocol/aztec-packages@2c199d8)) ### Miscellaneous * Explanations about skippable ([#11984](AztecProtocol/aztec-packages#11984)) ([19589bc](AztecProtocol/aztec-packages@19589bc)) * Op wires index from 0 ([#11986](AztecProtocol/aztec-packages#11986)) ([be1b563](AztecProtocol/aztec-packages@be1b563)) * Some polishing on the skippable document ([#11997](AztecProtocol/aztec-packages#11997)) ([50e0a38](AztecProtocol/aztec-packages@50e0a38)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

This was referenced Jan 29, 2025

feat(avm): constrain sha256 #11048

Merged

fix: hardcode value in constants #11442

Merged

feat(avm): constrained ec_add #11525

Merged

IlyasRidhuan force-pushed the ir/01-10-feat_avm_constrained_ec_add branch 2 times, most recently from 5a378e0 to d916f01 Compare January 30, 2025 19:01

IlyasRidhuan force-pushed the ir/01-10-feat_avm_constrained_ec_add branch from d916f01 to c176d6c Compare February 10, 2025 15:07

IlyasRidhuan force-pushed the ir/01-28-feat_poseidon2_in_vm2 branch 2 times, most recently from 038aa43 to 9e80f24 Compare February 10, 2025 16:23

IlyasRidhuan force-pushed the ir/01-10-feat_avm_constrained_ec_add branch 2 times, most recently from 35fce8a to b103a20 Compare February 12, 2025 14:03

IlyasRidhuan force-pushed the ir/01-28-feat_poseidon2_in_vm2 branch from 9e80f24 to 8ea0328 Compare February 12, 2025 14:10

IlyasRidhuan marked this pull request as ready for review February 12, 2025 14:26

IlyasRidhuan requested review from Maddiaa0, fcarreiro and jeanmon as code owners February 12, 2025 14:26

IlyasRidhuan force-pushed the ir/01-10-feat_avm_constrained_ec_add branch from b103a20 to 7883080 Compare February 12, 2025 15:59

fcarreiro reviewed Feb 12, 2025

View reviewed changes

IlyasRidhuan force-pushed the ir/01-10-feat_avm_constrained_ec_add branch from 7883080 to 73f9803 Compare February 12, 2025 22:57

IlyasRidhuan force-pushed the ir/01-28-feat_poseidon2_in_vm2 branch 2 times, most recently from 0b4fd1c to 09bac87 Compare February 13, 2025 09:07

IlyasRidhuan force-pushed the ir/01-10-feat_avm_constrained_ec_add branch from 73f9803 to dece8ee Compare February 13, 2025 09:46

IlyasRidhuan force-pushed the ir/01-28-feat_poseidon2_in_vm2 branch from 09bac87 to 7bd3cc6 Compare February 13, 2025 09:46

Base automatically changed from ir/01-10-feat_avm_constrained_ec_add to master February 13, 2025 10:32

IlyasRidhuan force-pushed the ir/01-28-feat_poseidon2_in_vm2 branch from 7bd3cc6 to 2df2297 Compare February 13, 2025 16:56

fcarreiro reviewed Feb 13, 2025

View reviewed changes

IlyasRidhuan force-pushed the ir/01-28-feat_poseidon2_in_vm2 branch from 2df2297 to 3b7e83a Compare February 13, 2025 21:21

feat: poseidon2 in vm2

ee53456

IlyasRidhuan force-pushed the ir/01-28-feat_poseidon2_in_vm2 branch from 3b7e83a to ee53456 Compare February 14, 2025 11:19

fcarreiro approved these changes Feb 14, 2025

View reviewed changes

IlyasRidhuan merged commit 2c199d8 into master Feb 14, 2025

IlyasRidhuan deleted the ir/01-28-feat_poseidon2_in_vm2 branch February 14, 2025 12:43

AztecBot mentioned this pull request Feb 14, 2025

chore(master): Release 0.77.0 #11985

Merged

fcarreiro changed the title ~~feat: poseidon2 in vm2~~ feat(avm): poseidon2 in vm2 Feb 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(avm): poseidon2 in vm2#11597

feat(avm): poseidon2 in vm2#11597
IlyasRidhuan merged 1 commit intomasterfrom
ir/01-28-feat_poseidon2_in_vm2

IlyasRidhuan commented Jan 29, 2025

Uh oh!

IlyasRidhuan commented Jan 29, 2025 •

edited

Loading

Uh oh!

fcarreiro left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fcarreiro Feb 12, 2025

Uh oh!

IlyasRidhuan Feb 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fcarreiro left a comment

Uh oh!

fcarreiro Feb 13, 2025

Uh oh!

fcarreiro Feb 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		std::vector<Poseidon2PermutationEvent> event_results = perm_event_emitter.dump_events();

		EXPECT_EQ(result, expected);

Conversation

IlyasRidhuan commented Jan 29, 2025

Uh oh!

IlyasRidhuan commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fcarreiro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fcarreiro Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

IlyasRidhuan Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fcarreiro left a comment

Choose a reason for hiding this comment

Uh oh!

fcarreiro Feb 13, 2025

Choose a reason for hiding this comment

Uh oh!

fcarreiro Feb 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IlyasRidhuan commented Jan 29, 2025 •

edited

Loading