Skip to content

chore: make tests not silent if DEBUG set #10130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 4 commits into from
Nov 22, 2024
Merged

chore: make tests not silent if DEBUG set #10130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
103990b
chore: make tests not silent if DEBUG set
ludamad Nov 22, 2024
7bcf0b1
Update package.json
ludamad Nov 22, 2024
405fcc2
Update package.local.json
ludamad Nov 22, 2024
72a2fb2
Merge branch 'master' into ad/test-logs-with-debug
ludamad Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions yarn-project/foundation/src/log/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,14 @@ export type LogLevel = (typeof LogLevels)[number];

function getLogLevel() {
const envLogLevel = process.env.LOG_LEVEL?.toLowerCase() as LogLevel;
const defaultNonTestLogLevel =
process.env.DEBUG === undefined || process.env.DEBUG === '' ? ('info' as const) : ('debug' as const);
const defaultLogLevel = process.env.NODE_ENV === 'test' ? ('silent' as const) : defaultNonTestLogLevel;
let defaultLogLevel: LogLevel = 'info';
if (process.env.DEBUG) {
// if we set DEBUG to a non-empty string, use debug as default
defaultLogLevel = 'debug';
} else if (process.env.NODE_ENV === 'test') {
// otherwise, be silent in tests as these are frequently ran en-masse
defaultLogLevel = 'silent';
}
return LogLevels.includes(envLogLevel) ? envLogLevel : defaultLogLevel;
}

Expand Down
2 changes: 1 addition & 1 deletion yarn-project/prover-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"formatting": "run -T prettier --check ./src && run -T eslint ./src",
"formatting:fix": "run -T eslint --fix ./src && run -T prettier -w ./src",
"bb": "node --no-warnings ./dest/bb/index.js",
"test": "LOG_LEVEL=${LOG_LEVEL:-silent} DEBUG_COLORS=1 NODE_NO_WARNINGS=1 node --experimental-vm-modules ../node_modules/.bin/jest --testTimeout=1500000 --forceExit",
"test": "DEBUG_COLORS=1 NODE_NO_WARNINGS=1 node --experimental-vm-modules ../node_modules/.bin/jest --testTimeout=1500000 --forceExit",
"test:debug": "LOG_LEVEL=debug DEBUG_COLORS=1 NODE_NO_WARNINGS=1 node --experimental-vm-modules ../node_modules/.bin/jest --testTimeout=1500000 --forceExit --testNamePattern prover/bb_prover/parity"
},
"jest": {
Expand Down
2 changes: 1 addition & 1 deletion yarn-project/prover-client/package.local.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"scripts": {
"test": "LOG_LEVEL=${LOG_LEVEL:-silent} DEBUG_COLORS=1 NODE_NO_WARNINGS=1 node --experimental-vm-modules ../node_modules/.bin/jest --testTimeout=1500000 --forceExit"
"test": "DEBUG_COLORS=1 NODE_NO_WARNINGS=1 node --experimental-vm-modules ../node_modules/.bin/jest --testTimeout=1500000 --forceExit"
}
}