Skip to content

WindowStartupLocation DPI-awareness #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OronDF343 wants to merge 7 commits into from
Closed

WindowStartupLocation DPI-awareness #1979

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ae77d43
WindowStartupLocation DPI-awareness
OronDF343 Oct 18, 2018
fc04463
Merge branch 'master' into wsldpifix
Oct 26, 2018
04e193e
Merge branch 'master' into wsldpifix
Oct 26, 2018
7abfa5e
Merge branch 'master' into wsldpifix
Oct 26, 2018
a826638
Merge branch 'master' into wsldpifix
OronDF343 Oct 30, 2018
e4e1bb7
Merge branch 'master' into wsldpifix
Nov 17, 2018
a25e848
Merge branch 'master' into wsldpifix
grokys Jan 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Avalonia.Controls/Window.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,18 +462,19 @@ void SetIsEnabled(IEnumerable<Window> windows, bool isEnabled)

void SetWindowStartupLocation()
{
var scaling = PlatformImpl?.Scaling ?? 1;
if (WindowStartupLocation == WindowStartupLocation.CenterScreen)
{
var screen = Screens.ScreenFromPoint(Bounds.Position);

if (screen != null)
Position = screen.WorkingArea.CenterRect(new Rect(ClientSize)).Position;
Position = screen.WorkingArea.CenterRect(new Rect(ClientSize * scaling)).Position;
Copy link

@danwalmsley danwalmsley Oct 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately this doesn't work for me.

image

Copy link
Contributor Author

@OronDF343 OronDF343 Oct 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is because the ClientSize is being treated as screen pixels somewhere and isn't being scaled. This is probably a backend-specific bug as I'm not getting it on Win32.

Which backend are you running on?

Copy link
Member

@grokys grokys Nov 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danwalmsley any further info here?

}
else if (WindowStartupLocation == WindowStartupLocation.CenterOwner)
{
if (Owner != null)
{
var positionAsSize = Owner.ClientSize / 2 - ClientSize / 2;
var positionAsSize = (Owner.ClientSize / 2 - ClientSize / 2) * scaling;
Position = Owner.Position + new Point(positionAsSize.Width, positionAsSize.Height);
}
}
Expand Down