-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Remove Sprache dependency #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Sprache dependency #1668
Conversation
…zinsky/Avalonia into selector-parse-no-sprache
|
Looks like because of dotnet/android#1679 (comment) the Span-ified vesion is blocked on release of Visual Studio 15.8. |
jmacato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Looks GREAT to me)!
Depends on #1667
Change
SelectorGrammarto use theReaderclass used in binding path parsing (moved up to Avalonia.Markup in Allow LINQ Expressions for Binding Expressions #1667). Also, updateReaderto be aref structwith aReadOnlySpan<char>to represent the member.I've included some perf numbers below:
Sprache is the code in master. No Sprache is a Selector parser based on the
Readerclass that still uses strings andStringBuilders. Span-ified is the version at the tip of this PR branch (1133c3e).Checklist: