Expose RippleEffect.RaiseRipple and RaiseRippleAbsoluteCoord function#453
Merged
appleneko2001 merged 6 commits intoAvaloniaCommunity:masterfrom May 14, 2025
appleneko2001:master
Merged
Expose RippleEffect.RaiseRipple and RaiseRippleAbsoluteCoord function#453appleneko2001 merged 6 commits intoAvaloniaCommunity:masterfrom appleneko2001:master
appleneko2001 merged 6 commits intoAvaloniaCommunity:masterfrom
appleneko2001:master
Conversation
SKProCH
requested changes
May 2, 2025
Collaborator
|
Why do you want to merge to |
Contributor
Author
i remember that previous PR did same thing |
Collaborator
I also have the same question about the previous PR. :) If there is no specific reason we can target master |
This was referenced Jul 24, 2025
This was referenced Jan 1, 2026
This was referenced Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This will make
RippleEffectusable as a element that can guide user which things are they looking for, or make it raisable by keyboard or any source.Exposed API
RippleEffect.RaiseRippleRaise a ripple element at the coordinate. By default it will raise at center point of the bound ofRippleEffectcontroldouble nX = 0.5normalised X coordinate, valid range: [0.0 - 1.0]double nY = 0.5normalised Y coordinate, valid range: [0.0 - 1.0]RippleEffect.RaiseRippleAbsoluteCoordRaise a ripple element at the non-normalised coordinates. (acquired by Expose RippleEffect.RaiseRipple and RaiseRippleAbsoluteCoord function #453 (comment))double xX coordinate, should be in bounds of theRippleEffectdouble yY coordinate, should be in bounds of theRippleEffectContext
#450 (comment)
#450 (comment)
Changes
AutomationAssistclass to contains examples for advanced automation usages of the theming library and AvaloniaUI framework, the implementation should be easy to understand, also they cannot be added directly in library but should be "attachable".IsClickedattached property to theAutomationAssistof theMaterial.Avalonia.Demo, and add button clicked observer to theAutomationAssist, this desicion have been made in PR Add HyperlinkButton theming support #450 (review) which we should make it as a usage example rather than integrating it to the libraryFloatingButtoncontrol template, which theRippleEffectdidnt have name to satisfy predication of functionRaiseRipplePrivateRippleEffectand expose APIRaiseRippleandRaiseRippleAbsoluteCoord. This API usage will be demonstrated in the demo project.