Skip to content

Upgrade dependences to polkadot-v0.9.13#50

Merged
irsal merged 6 commits intomasterfrom
polkadot-v0.9.13
Jan 12, 2022
Merged

Upgrade dependences to polkadot-v0.9.13#50
irsal merged 6 commits intomasterfrom
polkadot-v0.9.13

Conversation

@imstar15
Copy link
Copy Markdown
Contributor

@imstar15 imstar15 commented Jan 10, 2022

FYI:

  1. The --parachain-id parameter in the CLI command has been removed.
    !!!Please configure parachain_id through the exported chain spec file.

  2. I added the rust-toolchain.toml file to specify the version and target of the rust toolchain.
    If the corresponding component is not installed on the machine, it will be installed automatically at build time.

Refer to:
paritytech/cumulus#739

@imstar15
Copy link
Copy Markdown
Contributor Author

imstar15 commented Jan 10, 2022

The latest rust nightly version on Ubuntu has a bug that will cause build polkadot-v0.9.13 to fail, so the check action will fail.
https://githubmate.com/index.php/repo/bytecodealliance/rustix/issues/142

It is recommended to use version nightly-2021-12-15.

const TOTAL_TOKENS: u128 = DOLLAR * 1_000_000_000;
static RELAY_CHAIN: &str = "rococo-local";
static NEUMANN_RELAY_CHAIN: &str = "rococo-testnet";
const DEFAULT_PARA_ID: u32 = 1000;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2000

@chrisli30
Copy link
Copy Markdown
Member

The latest rust nightly version on Ubuntu has a bug that will cause build polkadot-v0.9.13 to fail, so the check action will fail. https://githubmate.com/index.php/repo/bytecodealliance/rustix/issues/142

It is recommended to use version nightly-2021-12-15.

I think we can lock the version "nightly-2021-12-15" for the CI to use. There‘s no need to upgrade Rust library real-time.

@irsal
Copy link
Copy Markdown
Contributor

irsal commented Jan 11, 2022

I'll take over this PR as well.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 11, 2022

Codecov Report

Merging #50 (d9a88e5) into master (1197ba5) will increase coverage by 21.09%.
The diff coverage is 71.29%.

❗ Current head d9a88e5 differs from pull request most recent head b37eec0. Consider uploading reports for the commit b37eec0 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master      #50       +/-   ##
===========================================
+ Coverage   22.75%   43.84%   +21.09%     
===========================================
  Files           5        7        +2     
  Lines         290      504      +214     
===========================================
+ Hits           66      221      +155     
- Misses        224      283       +59     
Impacted Files Coverage Δ
runtime/neumann/src/lib.rs 20.15% <ø> (ø)
pallets/automation-time/src/mock.rs 35.71% <35.71%> (ø)
pallets/automation-time/src/lib.rs 47.50% <51.88%> (+41.25%) ⬆️
pallets/automation-time/src/tests.rs 97.91% <97.91%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e04eb53...b37eec0. Read the comment docs.

@imstar15
Copy link
Copy Markdown
Contributor Author

imstar15 commented Jan 11, 2022

I added the rust-toolchain.toml file to specify the version and target of the rust toolchain.
If the corresponding component is not installed on the machine, it will be installed automatically at build time.

@imstar15 imstar15 requested a review from irsal January 11, 2022 05:20
@irsal irsal removed request for chrisli30 and irsal January 12, 2022 20:52
description = "Pallet for scheduling and running tasks in the future."
version = "0.0.0"
edition = "2021"
edition = "2018"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2018?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't effectively switched to rust 2021. Depending on your toolchain, it might force you to update the rust config to edition2021. We should move to 2021 in a future pr (like soon)

@irsal irsal merged commit 6db2dae into master Jan 12, 2022
@irsal irsal deleted the polkadot-v0.9.13 branch January 12, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants