MSD Billing: Fix cancel skip link and skip survey if already sent #107193
+51
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SHILL-1308
Proposed Changes
Why are these changes being made?
Testing Instructions
Test "skip" functionality.
/v2/me/billing/purchasesand click "manage purchase" for an active purchase that is outside of the refund window. (Refunds will cancel and remove - we'd like to test those flows separately to make sure the preference is set and received correctly)./cancelto the end of URL and view the resulting page./cancelto the URL as before.Test skipping survey on remove if submitted on cancel
/v2/me/billing/purchasesand click "manage purchase" for an active WPCom plan purchase that is outside of the refund window. (Refunds will cancel and remove - we'd like to test those flows separately to make sure the preference is set and received correctly)./cancelto the end of URL and view the resulting page./cancelto the URL as before.Pre-merge Checklist