Skip to content

Conversation

@valterlorran
Copy link
Contributor

Closes DOTCOM-15229

Proposed Changes

  • Fix the disabled color for the Radio button on the Securely share your access step.
Before
Captura de Tela 2025-11-18 às 16 03 55
After
Captura de Tela 2025-11-18 às 15 59 44

Why are these changes being made?

  • While the Share SSH access step was loading, the radio input would appear not be selected.

Testing Instructions

  • Visual inpsection should be enough.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@valterlorran valterlorran self-assigned this Nov 18, 2025
@valterlorran valterlorran requested a review from Copilot November 18, 2025 19:04
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 18, 2025
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a visual bug in the SSH migration flow where disabled radio buttons appeared unselected during the loading state. The fix updates the background color of disabled checked radio buttons from white (--color-neutral-0) to a visible gray (--color-neutral-40).

Key Changes:

  • Updated the disabled checked radio button styling to use a darker color that shows the selected state

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@matticbot
Copy link
Contributor

matticbot commented Nov 18, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/ssh-migration-radio-selected-state on your sandbox.

@valterlorran valterlorran force-pushed the fix/ssh-migration-radio-selected-state branch from c27078b to 23ae54c Compare November 19, 2025 13:26
@valterlorran valterlorran force-pushed the fix/ssh-migration-radio-selected-state branch from 23ae54c to 3ca0fe3 Compare November 19, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants