-
Notifications
You must be signed in to change notification settings - Fork 2k
CIAB: add Woo Hosted Plans stepper flow #107163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
packages/onboarding/src/step-container-v2/components/TopBar/TopBar.tsx
Outdated
Show resolved
Hide resolved
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
packages/onboarding/src/step-container-v2/components/TopBar/TopBar.tsx
Outdated
Show resolved
Hide resolved
8d71f42 to
437f6b9
Compare
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~107 bytes added 📈 [gzipped]) Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~1541 bytes added 📈 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~91 bytes added 📈 [gzipped]) React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
|
|
||
| /** | ||
| * Hide the logo entirely. | ||
| */ | ||
| hideLogo?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get rid of this property now that we're hiding the logo if logo={ null }?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I much prefer hiding the logo when it's explicitly null rather than using the hideLogo boolean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now that we're hiding the logo if logo={ null }
I removed that from this diff, but can switch back if you want.
I originally went with the null value for the logo prop, but the rendering logic was clunky. You can see it in 7636cec. Checking for the explicit null value, since logo could also be undefined felt strange, so I pinged @sirbrillig for his thoughts. He made a really good case for the prop - effectively that it's better to have a prop have a singular purpose instead of trying to represent different states. In this case logo is used to declare which logo to use, while hideLogo is used to declare whether or not to show a logo.
@zaguiini since y'all maintain the stepper flow I'll defer to you, but do you still feel that the logo={ null } is the way to go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, hideLogo is indeed more explicit. Let's remove the comment in the logo type definition, then. 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh 🤦🏻 - I lost that in a forced rebase. I'll update it - thanks!
437f6b9 to
649c7aa
Compare
|
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/30827324 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Hi @michaeldcain, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
Fixes: https://linear.app/a8c/issue/SHILL-929/ciab-create-checkout-flow-for-ciab
Proposed Changes
This adds a basic stepper flow, based on the
plans-upgradeflow, that allows a Woo Hosted (CIAB) site to pick a paid plan and be directed to Checkout. As part of the work, it adds the basic plumbing to render the Woo Hosted plans grid, which can be used by different flows.Why are these changes being made?
When a CIAB site is provisioned with a free trial, the user will be prompted to upgrade their site through a Stepper flow. A previous version of this exists in #106279, but a plans-specific flow was requested after internal review.
Testing Instructions
calypso.localhost:3000/setup/woo-hosted-plans?siteSlug={yourciabsiteaddress}