Skip to content

Conversation

@ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented Nov 18, 2025

Related issues

N/A

Proposed Changes

  • fix several lint errors in E2E tests

Testing Instructions

  1. Check out the PR branch.
  2. Run npm run lint. It should pass.
  3. Run npm run e2e -- e2e/import-export.test.ts. I should still pass.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@ivan-ottinger ivan-ottinger self-assigned this Nov 18, 2025
@ivan-ottinger ivan-ottinger requested a review from a team November 18, 2025 14:33
@ivan-ottinger ivan-ottinger marked this pull request as ready for review November 18, 2025 15:08
@ivan-ottinger
Copy link
Contributor Author

ivan-ottinger commented Nov 18, 2025

Thanks for the review, Wojtek! 🙂

I have pushed one additional small improvement (c87551e) and once the test pass, I will merge the PR.

@github-actions
Copy link
Contributor

📊 Performance Test Results

Comparing 2547549 vs trunk

site-editor

Metric trunk 2547549 Diff Change
load 7776.00 ms 9612.00 ms +1836.00 ms 🔴 23.6%

site-startup

Metric trunk 2547549 Diff Change
siteCreation 14059.00 ms 15081.00 ms +1022.00 ms 🔴 7.3%
siteStartup 4985.00 ms 4922.00 ms -63.00 ms 🟢 -1.3%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@ivan-ottinger ivan-ottinger merged commit 64b581c into trunk Nov 18, 2025
8 of 9 checks passed
@ivan-ottinger ivan-ottinger deleted the fix/e2e-test-lint-errors branch November 18, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants