Skip to content

Conversation

@sejas
Copy link
Member

@sejas sejas commented Nov 18, 2025

Proposed Changes

  • Fix eslint errors in e2e sites test

Testing Instructions

  • Run npm run lint.
  • Observe zero errors.
  • CI should pass.
Screenshot 2025-11-18 at 10 30 53

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@sejas sejas self-assigned this Nov 18, 2025
@sejas sejas requested a review from a team November 18, 2025 10:30
@sejas sejas merged commit 49165a3 into trunk Nov 18, 2025
7 of 10 checks passed
@sejas sejas deleted the fix/eslint-errors-on-e2e-sites-test branch November 18, 2025 10:32
@github-actions
Copy link
Contributor

📊 Performance Test Results

Comparing ba564be vs trunk

site-editor

Metric trunk ba564be Diff Change
load 13694.00 ms 16550.00 ms +2856.00 ms 🔴 20.9%

site-startup

Metric trunk ba564be Diff Change
siteCreation 24249.00 ms 24142.00 ms -107.00 ms 🟢 -0.4%
siteStartup 7984.00 ms 7965.00 ms -19.00 ms 🟢 -0.2%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants