Skip to content

Capitalize "File Explorer" in the Windows shortcut label #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2025
Merged

Capitalize "File Explorer" in the Windows shortcut label #2020

merged 1 commit into from
Nov 6, 2025

Conversation

@ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented Nov 5, 2025 •
edited
Loading

Related issues

Proposed Changes

  • capitalize File Explorer in the Windows shortcut label
Before After
Screen Shot on 2025-11-05 at 17:39:56 Screen Shot on 2025-11-05 at 17:48:17

Testing Instructions

  1. Check out the PR branch and build the app with npm install and npm start on Windows.
  2. Ensure the File Explorer shortcut label is capitalized.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@ivan-ottinger ivan-ottinger self-assigned this Nov 5, 2025
@ivan-ottinger ivan-ottinger marked this pull request as ready for review November 5, 2025 16:50
@ivan-ottinger ivan-ottinger requested a review from a team November 5, 2025 16:51
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

📊 Performance Test Results

Comparing a88898d vs trunk

site-editor

Metric trunk a88898d Diff Change
load 9142.00 ms 6605.00 ms -2537.00 ms 🟢 -27.8%

site-startup

Metric trunk a88898d Diff Change
siteCreation 22324.00 ms 18216.00 ms -4108.00 ms 🟢 -18.4%
siteStartup 5933.00 ms 6963.00 ms +1030.00 ms 🔴 17.4%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

gcsecsey
gcsecsey approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@gcsecsey gcsecsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Image

epeicher
epeicher approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Before After
Image Image

@ivan-ottinger
Copy link
Contributor Author

ivan-ottinger commented Nov 6, 2025

Thanks for the reviews, Gergely and Roberto.

@ivan-ottinger ivan-ottinger merged commit 3d13aac into trunk Nov 6, 2025
13 checks passed
@ivan-ottinger ivan-ottinger deleted the update/file-explorer-name branch November 6, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epeicher epeicher epeicher approved these changes

@gcsecsey gcsecsey gcsecsey approved these changes

Assignees

@ivan-ottinger ivan-ottinger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ivan-ottinger @epeicher @gcsecsey