Skip to content

Conversation

@katinthehatsite
Copy link
Contributor

Related issues

Closes STU-969

Proposed Changes

This PR ensures that we limit depth on folders for mu-plugins when selecting items for push. This will ensure that it works consistently with themes and plugins.

Testing Instructions

  • Pull the changes from this branch
  • Start the app with npm start
  • In your Studio site, add a custom folder with a plugin to mu-plugins
  • Navigate to the Sync tab
  • Connect that Studio site to one of the WP.com sites
  • Click on Push option to open the Sync dialog`
  • Confirm that you can select the plugin folders for mu-plugins but you can't go deeper than that and that the behaviour is consistent with plugins and themes:
Screenshot 2025-11-05 at 11 09 49 AM

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@katinthehatsite katinthehatsite self-assigned this Nov 5, 2025
@katinthehatsite katinthehatsite requested a review from a team November 5, 2025 10:13
Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good and works as expected. 👌🏼

Before:

Image

After:

Image

Left just one minor comment.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

📊 Performance Test Results

Comparing 35afed1 vs trunk

site-editor

Metric trunk 35afed1 Diff Change
load 7293.00 ms 8097.00 ms +804.00 ms 🔴 11.0%

site-startup

Metric trunk 35afed1 Diff Change
siteCreation 11955.00 ms 12009.00 ms +54.00 ms 🔴 0.5%
siteStartup 3917.00 ms 3964.00 ms +47.00 ms 🔴 1.2%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for solving this. I agree that this should be consistent with plugins and themes. I have tested it, and I can see only one level more as expected. LGTM! :shipit:

Before After
Image Image

@katinthehatsite katinthehatsite merged commit 2ba5158 into trunk Nov 6, 2025
11 checks passed
@katinthehatsite katinthehatsite deleted the fix/depth-limit-on-mu-plugins branch November 6, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants