Skip to content

Conversation

@ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented Nov 4, 2025

Related issues

Proposed Changes

  • introduce new SyncSupport case: jetpack-disconnected
    • add related Check connection CTA linking to the Sync modal
    • ensure related warning is displayed in the Sync tab for already-connected sites
    • ensure that sites without proper Jetpack connection cannot be linked with local Studio sites
Sync tab Sync modal
Screen Shot on 2025-11-04 at 12:26:46 Screen Shot on 2025-11-04 at 12:28:31

Testing Instructions

  1. Check out the PR branch and build the app with npm install && npm start.
  2. Create a test Pressable site, connect it to your WPCOM account using Jetpack.
  3. Head over to the Sync tab of a local Studio site and connect the test Pressable site to the local site.
  4. Navigate to your Pressable dashboard and delete your test site there (this can be done from the bottom of the Site Actions section):
Screen Shot on 2025-11-04 at 14:53:34
  1. Review the Sync tab in Studio. There should now be information that the site is unreachable.
  2. Open the Sync modal. The site should be disabled and have Check connection link displayed on the side.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@ivan-ottinger ivan-ottinger self-assigned this Nov 4, 2025
@ivan-ottinger ivan-ottinger marked this pull request as ready for review November 4, 2025 13:56
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

📊 Performance Test Results

Comparing 836a441 vs trunk

site-editor

Metric trunk 836a441 Diff Change
load 9298.00 ms 9396.00 ms +98.00 ms 🔴 1.1%

site-startup

Metric trunk 836a441 Diff Change
siteCreation 13019.00 ms 17096.00 ms +4077.00 ms 🔴 31.3%
siteStartup 3927.00 ms 4924.00 ms +997.00 ms 🔴 25.4%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@ivan-ottinger ivan-ottinger marked this pull request as draft November 4, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants