-
Notifications
You must be signed in to change notification settings - Fork 51
Migrate release uploads to Apps CDN #1422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 58 commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
47bc570
Upgrade wpmreleasetoolkit to v13 to use upload_build_to_apps_cdn
sejas f878fb0
fix extension of generate-releases-manifest.mjs mentioned on versioni…
sejas 27f324f
change domain on generate-releases-manifest.mjs
sejas 47f46d6
Merge branch 'trunk' of github.com:Automattic/studio into update/STU-…
sejas f9bc65e
fix typo
sejas cc0b1f7
Update Gemfile.lock
sejas 382cceb
Implement Apps CDN upload logic with dry run
sejas 973e0d8
Site id needs to be a string
sejas ba21514
Log result
sejas a54c02f
Update platform to be mac any
sejas 0236425
Fix arguments
sejas f06c86a
Add console.log
sejas 8e3b915
update comments on generate releases manifest
sejas cd1ede3
Update dry run media_url
sejas 224f41a
Remove unused assemble_filename
sejas 7f29ac0
change order of the parameters
sejas a3a7663
Remove parameter values as they are not necessary on ruby
sejas 945e132
Update platform using correct platform name: "Mac - Silicon"
sejas 43ecbb1
Move release notes inside the loop
sejas d3316f3
Move release notes out of the loop
sejas 5b99823
Update fastlane-plugin-wpmreleasetoolkit library
sejas 7d572f6
Update manifest platform for releases.json
sejas ab2725f
Update build_type to Nightly instead of Alpha
sejas 8f70f2a
Improve the build_type definition
sejas 63181b3
Remove calls to generate-release-manifest
sejas 68b444b
Remove generate-releases-manifest.mjs
sejas 81e4632
Remove releases.json fastlane upload
sejas f549f27
Merge branch 'trunk' of github.com:Automattic/studio into update/STU-…
sejas 02e65b9
Move build_type closer to its usage
sejas 568e6d1
add install type and sha for windows and mac updates
sejas f643d44
update wpmreleasetoolkit to 13.3
sejas 4c993f8
Merge branch 'trunk' of github.com:Automattic/studio into update/STU-…
sejas 5d8603c
add build_type and version based on release_tag
sejas 24a0f9d
clean fastlane script
sejas e996871
upload only updates when no release_tag is present
sejas 8684b4e
Remove Mac Universal aka Mac - Any
sejas 8981d5b
update readme to mention our Studio endpoint
sejas 89ba34f
Undo selection on the Slack message. We expect every build to have th…
sejas 543309e
Identify beta build type
sejas 19c8c03
Merge branch 'trunk' of github.com:Automattic/studio into update/STU-…
sejas 2e73c52
Merge branch 'trunk' of github.com:Automattic/studio into update/STU-…
sejas 9cd8a16
upload binary appending the version name
sejas 09aa321
Merge branch 'trunk' of github.com:Automattic/studio into update/STU-…
sejas fe1ddfc
Update gemfile.lock after bundle install
sejas 98766c6
Fix comma in new appx definition
sejas 755a8ea
Remove sha from full installs
sejas f86ad35
Merge branch 'trunk' of github.com:Automattic/studio into update/STU-…
sejas e3b2f0f
Add Microsoft Store platform for Appx
sejas c0c1da8
Update fastlane-plugin-wpmreleasetoolkit
sejas 6c0cb43
Merge branch 'trunk' of github.com:Automattic/studio into update/STU-…
sejas e3831ab
Merge branch 'trunk' of github.com:Automattic/studio into update/STU-…
sejas e66a3ef
Merge branch 'trunk' of github.com:Automattic/studio into update/STU-…
sejas af3ccb9
Add support for Windows and Microsoft Store arm64
sejas 0fb2e7e
Update wpmreleasetoolkit Gemfile to 13.6
sejas 825ff6b
Fix indentation
sejas 7f060c6
Update Gemfile.lock
sejas afc353b
Add arch to filenames to produce unique filenames
sejas 42ee4c9
Update wpmreleasetoolkit to 13.7.0
sejas 944f719
Move the WPCOM_API_TOKEN check to the very top
sejas 1e93d8e
Update SHA1 error message for Windows RELEASES file
sejas 95d4b5e
Merge branch 'trunk' of github.com:Automattic/studio into update/STU-…
sejas 92bbbc9
Improve Dry Run messages
sejas 87b24e7
Unify version and suffix for dev and production builds
sejas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hitting that URL returns:
{"url":"https:\/\/cdn.a8c-ci.services\/studio\/studio-darwin-arm64-v1.6.2-dev64.app.zip"}The way I read this line, it means that for each platform and architecture Apps CDN uses
https://public-api.wordpress.com/wpcom/v2/studio-app/updates?platform=<platform>&arch=<arch>&version=<latest version?>to get the values to put in the JSON. cc @hannahtinklerThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial idea was to generate and upload the releases.json to the old CDN, but we decided to create the equivalent version in our infrastructure https://appscdn.wordpress.com/builds/wordpress-com-studio/releases.json . That file is generated dynamically.
We can optimize the logic in the near future and Studio endpoint could
https://public-api.wordpress.com/wpcom/v2/studio-app/updatescould access the builds in the database and return the URL without needing the intermediaryreleases.json, but that can be a follow-up optimization. Also, I'm not sure if a similar logic is necessary for other Electron apps.