fix: remove "-popup" suffix from method params, no longer needed #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
miguelpeixe
approved these changes
May 5, 2025
matticbot
pushed a commit
that referenced
this pull request
May 7, 2025
# [3.5.0-alpha.3](v3.5.0-alpha.2...v3.5.0-alpha.3) (2025-05-07) ### Bug Fixes * remove "-popup" suffix from method params, no longer needed ([#1431](#1431)) ([843282e](843282e))
Contributor
|
🎉 This PR is included in version 3.5.0-alpha.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
May 14, 2025
# [3.5.0](v3.4.3...v3.5.0) (2025-05-14) ### Bug Fixes * pass popup ID param through order ([#1424](#1424)) ([2058424](2058424)) * remove "-popup" suffix from method params, no longer needed ([#1431](#1431)) ([843282e](843282e)) * **segmentation:** range criteria ([#1419](#1419)) ([c50d60a](c50d60a)) ### Features * **criteria:** option parameters ([#1421](#1421)) ([3ed2b4a](3ed2b4a)) * **segments:** add screen size criteria ([#1414](#1414)) ([5832984](5832984))
Contributor
|
🎉 This PR is included in version 3.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Proposes removing the
-popupsuffix from activityregistration_methodandlogin_methoddata, as this info can be inferred from the existence ofnewspack_popup_idorgate_post_idparams in the activity.How to test the changes in this Pull Request:
See Automattic/newspack-plugin#3956 (comment)
Other information: