-
Notifications
You must be signed in to change notification settings - Fork 55
feat: metered content countdown banner #4315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dkoo
wants to merge
15
commits into
trunk
Choose a base branch
from
feat/content-gate-meter-countdown
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Uses a fixed banner to display metering information, intended to be used as a simpler and more global alternative to #4176.
Repurposes existing admin and front-end assets from #4207 for efficiency.
Note that this includes a newNevermind, this component is only useful when used inside the block editor due to its dependency on theColorPaletteControlscomponent—I originally created this with the intention of being able to customize banner colors, but ultimately opted to use the same "light"/"dark" toggle as the content gifting banner instead. I think the component might come in handy in the future, so I left it in, but it's unused for now.ColorPaletteControlcomponent from the@wordpress/block-editorpackage. Importing this component outside of that context borks our Jest tests, so I'll bring it back but outside of the Components package if we need it in the future.Closes NPPM-2204.
How to test the changes in this Pull Request:
Other information: