feat(collections): add logic for opening links in new tabs #4174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbcorrales
added
the
[Status] Needs Review
dkoo
approved these changes
Sep 11, 2025
dkoo
added
[Status] Approved
|
Hey @rbcorrales, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
rbcorrales
added a commit
that referenced
this pull request
Sep 18, 2025
matticbot
pushed a commit
that referenced
this pull request
Sep 18, 2025
# [6.19.0-alpha.4](v6.19.0-alpha.3...v6.19.0-alpha.4) (2025-09-18) ### Features * **collections:** add Collections block ([#4166](#4166)) ([ea0917b](ea0917b)) * **collections:** add logic for opening links in new tabs ([#4174](#4174)) ([ab71461](ab71461)) * **collections:** collections block feedback ([#4185](#4185)) ([2f203c1](2f203c1)) * **collections:** replace archive grid with collections block ([#4178](#4178)) ([d601445](d601445))
matticbot
pushed a commit
that referenced
this pull request
Sep 22, 2025
# [6.19.0](v6.18.3...v6.19.0) (2025-09-22) ### Bug Fixes * **indesign-export:** remove feature flag ([#4180](#4180)) ([e3c5c7e](e3c5c7e)) * **my-account:** missing variable and template hook priority ([#4150](#4150)) ([9886618](9886618)) * **newspack-ui:** border radius and padding for buttons, modals, and segmented controls ([#4162](#4162)) ([be750ef](be750ef)) * register with empty name fields ([#4175](#4175)) ([7d6680c](7d6680c)) ### Features * **collections:** add Collections block ([#4166](#4166)) ([ea0917b](ea0917b)) * **collections:** add logic for opening links in new tabs ([#4174](#4174)) ([ab71461](ab71461)) * **collections:** collections block feedback ([#4185](#4185)) ([2f203c1](2f203c1)) * **collections:** replace archive grid with collections block ([#4178](#4178)) ([d601445](d601445)) * **newspack-ui:** add standalone dropdown button; reorganise dropdown box; add generic spacing ([#4169](#4169)) ([863da1e](863da1e)) * **woocommerce:** add custom currency symbol option ([#4155](#4155)) ([8811a7e](8811a7e))
matticbot
pushed a commit
that referenced
this pull request
Sep 25, 2025
# [6.20.0-alpha.1](v6.19.0...v6.20.0-alpha.1) (2025-09-25) ### Bug Fixes * Improve help text for Guest Contributor checkbox ([#4187](#4187)) ([5790f3d](5790f3d)) * newspack-plugin delay ([#4184](#4184)) ([22e8dc2](22e8dc2)) * update download URL for db.php ([#4193](#4193)) ([4d363db](4d363db)) ### Features * **collections:** add Collections block ([#4166](#4166)) ([1185157](1185157)) * **collections:** add logic for opening links in new tabs ([#4174](#4174)) ([07a5545](07a5545)) * **collections:** collections block feedback ([#4185](#4185)) ([0d0210c](0d0210c)) * **collections:** remove feature flag ([#4195](#4195)) ([b1619ef](b1619ef)) * **collections:** replace archive grid with collections block ([#4178](#4178)) ([d0cbadd](d0cbadd)) * **content-gate:** add countdown block ([#4176](#4176)) ([f8fe757](f8fe757)) * **my-account:** subscription switch modal ([#4177](#4177)) ([28c26e7](28c26e7)) * subscription tier modal ([#4164](#4164)) ([4d6ebe2](4d6ebe2))
Contributor
|
🎉 This PR is included in version 6.20.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Oct 6, 2025
# [6.20.0](v6.19.0...v6.20.0) (2025-10-06) ### Bug Fixes * ga4 events for gate interactions and tiered modal ([#4209](#4209)) ([2d35768](2d35768)) * Improve help text for Guest Contributor checkbox ([#4187](#4187)) ([5790f3d](5790f3d)) * newspack-plugin delay ([#4184](#4184)) ([22e8dc2](22e8dc2)) * remove content gate countdown block ([0204e58](0204e58)) * update download URL for db.php ([#4193](#4193)) ([4d363db](4d363db)) ### Features * **collections:** add archive link in settings page ([#4203](#4203)) ([42694ec](42694ec)) * **collections:** add Collections block ([#4166](#4166)) ([1185157](1185157)) * **collections:** add css classes to meta elements ([#4208](#4208)) ([7fbf7e9](7fbf7e9)) * **collections:** add logic for opening links in new tabs ([#4174](#4174)) ([07a5545](07a5545)) * **collections:** collections block feedback ([#4185](#4185)) ([0d0210c](0d0210c)) * **collections:** remove feature flag ([#4195](#4195)) ([b1619ef](b1619ef)) * **collections:** replace archive grid with collections block ([#4178](#4178)) ([d0cbadd](d0cbadd)) * **content-gate:** add countdown block ([#4176](#4176)) ([f8fe757](f8fe757)) * **my-account:** subscription switch modal ([#4177](#4177)) ([28c26e7](28c26e7)) * subscription tier modal ([#4164](#4164)) ([4d6ebe2](4d6ebe2))
Contributor
|
🎉 This PR is included in version 6.20.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR adds some logic to make CTA links automatically open external links, attachments, and file downloads in new tabs while keeping internal navigation in the same tab.
Links that will open in a new tab:
attachment)Links that will keep loading in the current tab:
The logic includes three filters for customization:
newspack_collections_new_tab_file_extensions: For adding custom file extensionsnewspack_collections_new_tab_internal_hosts: For adding custom hosts that would be considered internalnewspack_collections_should_cta_open_in_new_tab: For complete behavior overrideLinks that open in new tabs include
rel="noopener noreferrer"for security.Closes NPPD-871.
How to test the changes in this Pull Request:
https://example.com), internal links (e.g., /about), attachments, links with a PDF extension and relative URLs to test the different behaviors.Other information: