Skip to content

fix(woocommerce): image handling in paginated block #4149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

fix(woocommerce): image handling in paginated block #4149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions includes/plugins/class-perfmatters.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,11 +223,22 @@ private static function get_defaults( $options = [] ) {
$options['lazyload']['youtube_preview_thumbnails'] = true;
$options['lazyload']['image_dimensions'] = true;

$parent_exclusions = empty( $options['lazyload']['lazy_loading_parent_exclusions'] ) ? [] : $options['lazyload']['lazy_loading_parent_exclusions'];
// Add our customizations to the front of the array to avoid confusion when editing the setting in the UI.
$options['lazyload']['lazy_loading_parent_exclusions'] = array_merge(
[ 'wp-block-jetpack-image-compare' ],
$parent_exclusions
$lazy_loading_exclusions = empty( $options['lazyload']['lazy_loading_exclusions'] ) ? [] : $options['lazyload']['lazy_loading_exclusions'];
$options['lazyload']['lazy_loading_exclusions'] = array_unique(
array_merge(
[
'attachment-woocommerce_thumbnail', // If WC product images are within a pagination, the pages loaded after pageload will not not have images handled otherwise.
],
$lazy_loading_exclusions
)
);
$parent_exclusions = empty( $options['lazyload']['lazy_loading_parent_exclusions'] ) ? [] : $options['lazyload']['lazy_loading_parent_exclusions'];
$options['lazyload']['lazy_loading_parent_exclusions'] = array_unique(
array_merge(
[ 'wp-block-jetpack-image-compare' ],
$parent_exclusions
)
);

// Fonts.
Expand Down