fix(clone): fix parent doc for map subdocuments and array subdocuments#15958
Merged
fix(clone): fix parent doc for map subdocuments and array subdocuments#15958
Conversation
… parentArray ref on subdocs
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes parent document references when cloning documents with Map subdocuments and array subdocuments. The changes ensure that cloned subdocuments properly point to their cloned parent structures rather than the original ones.
Changes:
- Added special handling for MongooseMap cloning to properly set parent references
- Fixed parentArray references for cloned array subdocuments to point to the cloned array
- Added options object isolation for document arrays to prevent reference pollution
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/helpers/clone.js | Added MongooseMap cloning logic and fixed parentArray handling for document arrays |
| test/document.test.js | Added comprehensive test suite covering Map subdocuments, array subdocuments, deleteOne isolation, and nested array scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vkarpov15
added a commit
that referenced
this pull request
Jan 13, 2026
fix(clone): fix parent doc for map subdocuments and array subdocuments
vkarpov15
added a commit
that referenced
this pull request
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15954
re #15901 #15904