types: support maxLength and minLength in SchemaTypeOptions#15570
Merged
types: support maxLength and minLength in SchemaTypeOptions#15570
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for camelCase property names (minLength and maxLength) in SchemaTypeOptions and updates documentation examples to consistently use the camelCase naming convention instead of the lowercase variants.
- Updates JSDoc examples to use
minLengthinstead ofminlength - Ensures consistent camelCase naming in code examples
- Improves developer experience by supporting both naming conventions
Comments suppressed due to low confidence (1)
lib/schema/string.js:395
- [nitpick] The variable name
minLengthconflicts with the property name being demonstrated. Consider using a more descriptive name likeminLengthValidatororminLengthConfigto avoid confusion.
* const minLength = [5, 'The value of path `{PATH}` (`{VALUE}`) is shorter than the minimum allowed length ({MINLENGTH}).'];
hasezoey
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support camelcase names in SchemaTypeOptions, and also make the docs consistently use the camelcase names in examples.
Examples