feat(mongoose): export base Connection and Collection classes#15548
Merged
feat(mongoose): export base Connection and Collection classes#15548
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds exports for the base Connection and Collection classes to the Mongoose global object to enable drivers to integrate against these base classes without importing the node-mongodb-native driver. The change addresses the issue where importing { Connection } from 'mongoose' triggers setDriver() and returns the current driver's Connection rather than the base class.
- Exports
BaseConnectionandBaseCollectionclasses on the Mongoose prototype - Adds TypeScript test coverage for the new base class exports
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/mongoose.js | Adds BaseConnection and BaseCollection exports with JSDoc documentation |
| test/types/base.test.ts | Adds TypeScript test to verify base class exports work correctly |
hasezoey
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Right now the Mongoose global doesn't export the base
ConnectionandCollectionclasses, which makes things tricky for drivers looking to integrate against the base Connection and Collection classes without the node-mongodb-native driver. That's becauseimport { Connection } from 'mongoose';triggerslib/index.js'ssetDriver()call, andConnectionis just a getter around the current driver'sConnection, so there's no way to get the base Connection class without importingmongoose/lib/connection.Examples