feat(model): add Model.createSearchIndexes()#15470
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new API, Model.createSearchIndexes(), to consolidate and simplify search index creation logic and moves the auto-index creation from Model.init() into a dedicated helper function. Key changes include:
- Refactoring Model.init() to call ensureSearchIndexes().
- Implementing a new Model.createSearchIndexes() public API with a clear doc block.
- Adjusting tests in test/model.test.js to validate the new API behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/model.test.js | Updated test to use the new createSearchIndexes() API and require reordering adjustments. |
| lib/model.js | Refactored Model.init() call and introduced the createSearchIndexes() function with documentation. |
Comments suppressed due to low confidence (1)
test/model.test.js:8691
- [nitpick] A duplicate require for sinon is present in this test case even though sinon is already imported earlier in the file. Consider removing the redundant require to improve code clarity.
const sinon = require('sinon');
hasezoey
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #15465
Summary
Moved logic for auto creating search indexes into
Model.createSearchIndexes().Examples