Conversation
AbdelrahmanHafez
requested review from
Copilot,
hasezoey and
vkarpov15
and removed request for
Copilot,
hasezoey and
vkarpov15
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #15447 by preventing double validation of nested maps in subdocuments.
- Updated _getPathsToValidate to skip paths ending with ".$*" (map schemas).
- Added two tests in test/types.map.test.js to validate deeply nested maps with various nesting depths.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/types.map.test.js | Added tests to verify proper validation behavior for nested map subdocuments. |
| lib/document.js | Modified _getPathsToValidate to ignore '.$*' paths representing map schemas. |
Collaborator
Author
|
Note to self: |
vkarpov15
approved these changes
Jun 9, 2025
Collaborator
vkarpov15
left a comment
vkarpov15
left a comment
There was a problem hiding this comment.
This is a reasonable fix. I was looking into this and hoping to find a further upstream fix where this path wasn't modified, but this fix works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #15447
The issue was that mongoose was double validating nested maps of subdocuments, once as the correct path, but then trying to validate
.$*which represents the map schema rather than the actual value of a path.The bug was in the
_getPathsToValidatefunction inlib/document.js. We were incorrectly treating map schema paths (paths ending with.$*) as actual document paths for validation. These$*paths represent the schema for Maps but are not actual document paths that should be validated.This PR ignores the
.$*"path" when getting paths to validate.