Skip to content

types: allow default function returning undefined with DocType override #15328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vkarpov15 merged 1 commit into from
Mar 26, 2025
Merged

types: allow default function returning undefined with DocType override #15328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/types/schema.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1746,3 +1746,12 @@ async function schemaDouble() {
const doc = await TestModel.findOne().orFail();
expectType<Types.Double | null | undefined>(doc.balance);
}

function defaultReturnsUndefined() {
const schema = new Schema<{ arr: number[] }>({
arr: {
type: [Number],
default: () => void 0
}
});
}
2 changes: 1 addition & 1 deletion types/schematypes.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ declare module 'mongoose' {
* The default value for this path. If a function, Mongoose executes the function
* and uses the return value as the default.
*/
default?: DefaultType<T> | ((this: EnforcedDocType, doc: any) => DefaultType<T>) | null;
default?: DefaultType<T> | ((this: EnforcedDocType, doc: any) => DefaultType<T> | null | undefined) | null;

/**
* The model that `populate()` should use if populating this path.
Expand Down
Loading