Skip to content

fix: avoid connection buffering on init if autoCreate: false #15247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vkarpov15 merged 1 commit into from
Feb 11, 2025
Merged

fix: avoid connection buffering on init if autoCreate: false #15247

vkarpov15 merged 1 commit into from
Feb 11, 2025

Conversation

@vkarpov15
Copy link
Collaborator

@vkarpov15 vkarpov15 commented Feb 10, 2025

Re: #15241

Summary

Re: discussiong from #15241, make it so that autoCreate: false prevents buffering in init().

Examples

@vkarpov15 vkarpov15 added this to the 8.10.1 milestone Feb 10, 2025
@vkarpov15 vkarpov15 mentioned this pull request Feb 10, 2025
Closed
2 tasks
@vkarpov15 vkarpov15 merged commit 61d16b0 into master Feb 11, 2025
75 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-15241 branch February 12, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

8.10.1

Development

Successfully merging this pull request may close these issues.

3 participants

@vkarpov15 @hasezoey