fix(model): disallow updateMany(update) and fix TypeScript types re: updateMany()
#15199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15190
Summary
#15190 points out that
Model.updateMany(obj)updates all documents usingobj, which is risky, especially given that our TypeScript types as written imply thatupdateparameter is optional, meaningupdateMany(obj)treatsobjasfilterrather thanupdate, but the runtime behavior is different.This PR specifically blocks
Model.updateMany(obj, null), while allowingModel.updateOne(obj)andQuery.prototype.updateMany(obj, null).Examples