Handle hydrating deeply nested populated docs with hydratedPopulatedDocs #15130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th virtual populate re: #15110
…dDocs option for hydrate()
AbdelrahmanHafez
approved these changes
Dec 28, 2024
hasezoey
approved these changes
Dec 28, 2024
Collaborator
hasezoey
left a comment
hasezoey
left a comment
There was a problem hiding this comment.
LGTM, though seeing the amount of changes done, i would recommend to put this in the next minor version.
Also some slight style changes to make it more dense & consistent across the 2 tests.
Co-authored-by: hasezoey <[email protected]>
Co-authored-by: hasezoey <[email protected]>
Collaborator
Author
|
Merging into 8.10, thanks for the feedback @hasezoey 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now
hydratedPopulatedDocsonly goes one level deep, with both virtuals and conventional populate. This PR makes hydratedPopulatedDocs recursive.Examples