types(connection): fix return type of withSession() by apparedev · Pull Request #14690 · Automattic/mongoose

apparedev · 2024-06-25T15:41:48Z

Summary

This fixes Connection.withSession()'s type definition, which currently doesn't seem to match the implementation [here].

Examples

(a test is added instead)

vkarpov15

Thanks 👍

apparedev added 2 commits June 25, 2024 23:39

test: add type test for Connection.withSession

561a580

feat: fix return type of Connection.withSession

cc63f69

vkarpov15 approved these changes Jun 25, 2024

View reviewed changes

vkarpov15 added this to the 8.4.4 milestone Jun 25, 2024

vkarpov15 merged commit f89868b into Automattic:master Jun 25, 2024

saileshbro mentioned this pull request Jul 16, 2024

[Snyk] Upgrade mongoose from 8.4.3 to 8.4.4 saileshbro/nutri.gram#186

Merged

akanchhaS mentioned this pull request Jul 17, 2024

[Snyk] Upgrade mongoose from 4.2.4 to 8.4.4 akanchhaS/github-goof-npm#1277

Open

jfnw-capco mentioned this pull request Jul 17, 2024

[Snyk] Upgrade mongoose from 8.4.0 to 8.4.4 capcodigital/global-challenge#269

Open

Gabo-Tech mentioned this pull request Jul 17, 2024

[Snyk] Upgrade mongoose from 5.13.14 to 8.4.4 Gabo-Tech/toDoList#293

Open

MinhhTien mentioned this pull request Jul 17, 2024

[Snyk] Upgrade mongoose from 8.1.0 to 8.4.4 Deco-Team/furnique-api#135

Closed

bryopsida mentioned this pull request Jul 17, 2024

[Snyk] Upgrade mongoose from 8.3.4 to 8.4.4 bryopsida/syslog-api#294

Closed

NotZarifGithub mentioned this pull request Jul 17, 2024

[Snyk] Upgrade mongoose from 8.0.2 to 8.4.4 NotZarifGithub/InspiroVerse---ReactPractice-MERN-#106

Open

Erenkrs mentioned this pull request Jul 17, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.4.4 Erenkrs/Uptime-Site#446

Open

This was referenced Jul 17, 2024

[Snyk] Upgrade mongoose from 8.4.3 to 8.4.4 yunji0387/football-standings-backend#14

Merged

[Snyk] Upgrade mongoose from 8.4.3 to 8.4.4 yunji0387/football-fixtures-backend#9

Merged

0xbites mentioned this pull request Jul 17, 2024

[Snyk] Upgrade mongoose from 8.4.3 to 8.4.4 0xbites/MuslimDaily#2

Open

DaveLuhman mentioned this pull request Jul 17, 2024

[Snyk] Upgrade mongoose from 8.4.3 to 8.4.4 DaveLuhman/toolkeeper#239

Closed

DulranS mentioned this pull request Jul 17, 2024

[Snyk] Upgrade mongoose from 8.0.0 to 8.4.4 DulranS/SDGP#24

Open

MihikaNigam mentioned this pull request Jul 17, 2024

[Snyk] Upgrade mongoose from 8.1.1 to 8.4.4 MihikaNigam/Secure-Full-Stack-Web-App-with-Login#98

Open

lholmquist mentioned this pull request Jul 17, 2024

[Snyk] Upgrade mongoose from 6.12.0 to 8.4.4 nodeshift/mern-workshop#223

Closed

carltrepanier mentioned this pull request Jul 17, 2024

[Snyk] Upgrade mongoose from 8.4.3 to 8.4.4 carltrepanier/threads_clone#182

Merged

This was referenced Jul 17, 2024

[Snyk] Upgrade mongoose from 8.0.0 to 8.4.4 DulranS/SpotifySocialApp#23

Open

[Snyk] Upgrade mongoose from 8.0.0 to 8.4.4 DulranS/TorrentingLol#23

Open

NotZarifGithub mentioned this pull request Jul 18, 2024

[Snyk] Upgrade mongoose from 8.0.2 to 8.4.4 NotZarifGithub/InspiroVerse---ReactPractice-MERN-#108

Open

akanchhaS mentioned this pull request Jul 18, 2024

[Snyk] Upgrade mongoose from 4.2.4 to 8.4.4 akanchhaS/github-goof-npm#1279

Open

Gabo-Tech mentioned this pull request Jul 18, 2024

[Snyk] Upgrade mongoose from 5.13.14 to 8.4.4 Gabo-Tech/toDoList#294

Open

MinhhTien mentioned this pull request Jul 18, 2024

[Snyk] Upgrade mongoose from 8.1.0 to 8.4.4 Deco-Team/furnique-api#136

Closed

Erenkrs mentioned this pull request Jul 18, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.4.4 Erenkrs/Uptime-Site#451

Open

ibrahim-mohamed-zaghloul mentioned this pull request Jul 18, 2024

[Snyk] Upgrade mongoose from 8.2.0 to 8.4.4 ibrahim-mohamed-zaghloul/Three-tier-app-k8s#1

Open

DulranS mentioned this pull request Jul 18, 2024

[Snyk] Upgrade mongoose from 8.0.0 to 8.4.4 DulranS/SDGP#25

Open

This was referenced Aug 19, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.5.1 Erenkrs/Uptime-Site#576

Open

[Snyk] Upgrade mongoose from 8.1.3 to 8.5.1 Erenkrs/Uptime-Site#581

Open

This was referenced Aug 21, 2024

[Snyk] Upgrade mongoose from 8.2.0 to 8.5.2 zntb/mern-food-ordering-app-backend#7

Merged

[Snyk] Upgrade mongoose from 8.2.2 to 8.5.2 zntb/property-pulse#15

Closed

akanchhaS mentioned this pull request Aug 21, 2024

[Snyk] Upgrade mongoose from 4.2.4 to 8.5.2 akanchhaS/github-goof-npm#1300

Open

Gabo-Tech mentioned this pull request Aug 21, 2024

[Snyk] Upgrade mongoose from 5.13.14 to 8.5.2 Gabo-Tech/toDoList#299

Open

MinhhTien mentioned this pull request Aug 21, 2024

[Snyk] Upgrade mongoose from 8.1.0 to 8.5.2 Deco-Team/furnique-api#146

Closed

lholmquist mentioned this pull request Aug 21, 2024

[Snyk] Upgrade mongoose from 6.12.0 to 8.5.2 nodeshift/mern-workshop#235

Closed

NotZarifGithub mentioned this pull request Aug 21, 2024

[Snyk] Upgrade mongoose from 8.0.2 to 8.5.2 NotZarifGithub/InspiroVerse---ReactPractice-MERN-#116

Open

aviraj1703 mentioned this pull request Aug 21, 2024

[Snyk] Upgrade mongoose from 8.1.0 to 8.5.2 aviraj1703/place-explorer#29

Open

Erenkrs mentioned this pull request Aug 21, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.5.2 Erenkrs/Uptime-Site#586

Open

ibrahim-mohamed-zaghloul mentioned this pull request Aug 21, 2024

[Snyk] Upgrade mongoose from 8.2.0 to 8.5.2 ibrahim-mohamed-zaghloul/Three-tier-app-k8s#5

Open

This was referenced Aug 21, 2024

[Snyk] Upgrade mongoose from 8.0.0 to 8.5.2 DulranS/SDGP#34

Open

[Snyk] Upgrade mongoose from 8.0.0 to 8.5.2 DulranS/SpotifySocialApp#28

Open

[Snyk] Upgrade mongoose from 8.0.0 to 8.5.2 DulranS/TorrentingLol#28

Open

MihikaNigam mentioned this pull request Aug 21, 2024

[Snyk] Upgrade mongoose from 8.1.1 to 8.5.2 MihikaNigam/Secure-Full-Stack-Web-App-with-Login#112

Open

nejidevelops mentioned this pull request Aug 21, 2024

[Snyk] Upgrade mongoose from 8.1.2 to 8.5.2 nejidevelops/expense-tracker#25

Open

Erenkrs mentioned this pull request Aug 22, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.5.2 Erenkrs/Uptime-Site#591

Open

nostoc mentioned this pull request Aug 22, 2024

[Snyk] Upgrade mongoose from 8.4.1 to 8.5.2 nostoc/Resume-Builder#6

Open

This was referenced Aug 23, 2024

[Snyk] Upgrade mongoose from 8.4.1 to 8.5.2 ypreiser/quiz#3

Closed

[Snyk] Upgrade mongoose from 8.2.4 to 8.5.2 ypreiser/emailServer#1

Open

Erenkrs mentioned this pull request Aug 23, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.5.2 Erenkrs/Uptime-Site#596

Open

H1B0B0 mentioned this pull request Aug 23, 2024

[Snyk] Upgrade mongoose from 8.1.2 to 8.5.2 H1B0B0/Kurama-chat#6

Merged

This was referenced Aug 24, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.5.2 Erenkrs/Uptime-Site#601

Open

[Snyk] Upgrade mongoose from 8.1.3 to 8.5.2 Erenkrs/Uptime-Site#606

Open

itsarraj mentioned this pull request Aug 26, 2024

[Snyk] Upgrade mongoose from 8.4.4 to 8.5.2 itsarraj/ToDoListManagementAPI#2

Open

Erenkrs mentioned this pull request Aug 26, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.5.2 Erenkrs/Uptime-Site#611

Open

zModz mentioned this pull request Aug 26, 2024

[Snyk] Upgrade mongoose from 8.2.1 to 8.5.2 zModz/ArmoryApp#4

Closed

This was referenced Aug 27, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.5.2 Erenkrs/Uptime-Site#616

Open

[Snyk] Upgrade mongoose from 8.1.3 to 8.5.2 Erenkrs/Uptime-Site#621

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

types(connection): fix return type of withSession()#14690

types(connection): fix return type of withSession()#14690
vkarpov15 merged 2 commits into
Automattic:masterfrom
apparedev:feat/type-withsession

apparedev commented Jun 25, 2024

Uh oh!

vkarpov15 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

apparedev commented Jun 25, 2024

Uh oh!

vkarpov15 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants