Pass options to clone instead of get in applyVirtuals.#14606
Merged
Conversation
vkarpov15
approved these changes
May 24, 2024
vkarpov15
left a comment
vkarpov15
left a comment
Collaborator
There was a problem hiding this comment.
Very good catch, thank you!
vkarpov15
added a commit
that referenced
this pull request
May 31, 2024
This was referenced Jun 22, 2024
This was referenced Jun 22, 2024
This was referenced Aug 4, 2024
This was referenced Aug 5, 2024
This was referenced Aug 7, 2024
This was referenced Aug 15, 2024
This was referenced Aug 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A bug introduced in v8.3.3 by #14543 caused
toJSONto not be executed for virtual sub documents. The issue is caused by theoptionsbeing incorrectly passed into thegetfunction instead of theclonefunction.Examples
I don't have an easy examples sorry, but I think the fix should be fairly evident. The intentions of #14543 was to pass
noDottedPath: trueto thegetfunction but it mistakenly included the clone options which should have been passed tocloneinstead, as on line 4139 below it.