fix(model): make Model.recompileSchema() also re-apply discriminators
#14500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
requested changes
Apr 6, 2024
Collaborator
hasezoey
left a comment
hasezoey
left a comment
There was a problem hiding this comment.
Looks good, though some test nitpicks
This was referenced May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14444
Summary
Right now
recompileSchema()applies most schema changes, but not additionalSchema.prototype.discriminator()orSchemaType.prototype.discriminator()calls. This PR makesrecompileSchema()go through and reapply every discriminator that was added to the schema.Examples