test: some cleanup re: #12890 #12919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
requested changes
Jan 17, 2023
Collaborator
hasezoey
left a comment
hasezoey
left a comment
There was a problem hiding this comment.
mostly looks good to me, though there are some places that have not been changed yet, or were changed back to not properly close in case of test failure
Co-authored-by: hasezoey <[email protected]>
Co-authored-by: hasezoey <[email protected]>
…mongoose into vkarpov15/test-cleanup-12890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Applied some suggestions from #12890. Mostly getting rid of unnecessary
connectionsToClose- left it in one case where it makes sense. Also refactored out someModel.watch()cases, and fixed a potential bug due to the MongoDB node driver continuing to poll after change stream is closed.Examples