feat(model): add mergeHooks option to Model.discriminator() to avoid duplicate hooks
#12542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid duplicate hooks Fix #12472
hasezoey
requested changes
Oct 8, 2022
Collaborator
hasezoey
left a comment
hasezoey
left a comment
There was a problem hiding this comment.
LGTM, but the new option is missing from the types
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12472
Summary
There isn't a good way for Mongoose to dedupe hooks other than checking if you have two functions that are
===. Deduping based ontoString()would prone to false positives with certain design patterns.So for cases where deduping is not going to work, like #12472, we now have a
mergeHooksoption toModel.discriminator().Model.discriminator(name, discriminatorSchema, { mergeHooks: false })makes Mongoose take the discriminator schema's hooks.Examples