Skip to content

Forms: disable export button if no form entries #45777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 7, 2025
Merged

Forms: disable export button if no form entries #45777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b43849e
Forms: disable export if no form entries
edanzer Nov 5, 2025
ef066f5
changelog
edanzer Nov 5, 2025
c5f68bd
Hide export on mobile menu if no entries
edanzer Nov 6, 2025
b624ece
Fix link space issue
edanzer Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/forms/changelog/update-forms-disable-export-button
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: changed

Forms: disable export button if no form entries.
15 changes: 9 additions & 6 deletions projects/packages/forms/src/dashboard/components/actions-dropdown-menu/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { useNavigate } from 'react-router';
*/
import useCreateForm from '../../hooks/use-create-form';
import useExportResponses from '../../hooks/use-export-responses';
import useInboxData from '../../hooks/use-inbox-data';
import ExportResponsesModal from '../export-responses-modal';

type ActionsDropdownMenuProps = {
Expand All @@ -23,6 +24,8 @@ const ActionsDropdownMenu = ( { exportData }: ActionsDropdownMenuProps ) => {
const { showExportModal, openModal, closeModal, onExport, autoConnectGdrive, exportLabel } =
useExportResponses();
const navigate = useNavigate();
const { totalItems, isLoadingData } = useInboxData();
const hasItems = ! isLoadingData && totalItems > 0;

const analyticsEvent = useCallback( () => {
jetpackAnalytics.tracks.recordEvent( 'jetpack_wpa_forms_landing_page_cta_click', {
Expand All @@ -44,12 +47,17 @@ const ActionsDropdownMenu = ( { exportData }: ActionsDropdownMenuProps ) => {
}, [ navigate ] );

const controls = [
{
icon: plus,
onClick: onCreateFormClick,
title: __( 'Create form', 'jetpack-forms' ),
},
{
icon: plugins,
onClick: onIntegrationsClick,
title: __( 'Integrations', 'jetpack-forms' ),
},
...( exportData.show
...( exportData.show && hasItems
Copy link
Contributor Author

@edanzer edanzer Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was suggested we also go ahead and hide the Export item on the mobile menu if there's nothing to export. As part of this, I moved the Create Form button up so Export is the last item. This reduces jumpiness. With the change, the Export button only appears when there are form entries on the current screen. But this also means it's hidden while form entries are loading.

If export button is higher up, the whole menu jumps as items load or are removed from, say, inbox or spam or trash.

Video
https://github.com/user-attachments/assets/0a067ffe-fde8-40ba-bbd6-7ddf8e06e7cd

? [
{
icon: download,
Expand All @@ -58,11 +66,6 @@ const ActionsDropdownMenu = ( { exportData }: ActionsDropdownMenuProps ) => {
},
]
: [] ),
{
icon: plus,
onClick: onCreateFormClick,
title: __( 'Create form', 'jetpack-forms' ),
},
];

return (
Expand Down
15 changes: 14 additions & 1 deletion projects/packages/forms/src/dashboard/inbox/export-responses/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@
* External dependencies
*/
import { Button } from '@wordpress/components';
import { __ } from '@wordpress/i18n';
import { download } from '@wordpress/icons';
/**
* Internal dependencies
*/
import ExportResponsesModal from '../../components/export-responses-modal';
import useExportResponses from '../../hooks/use-export-responses';
import useInboxData from '../../hooks/use-inbox-data';

import './style.scss';

Expand All @@ -21,14 +23,25 @@ const ExportResponsesButton = () => {
autoConnectGdrive,
exportLabel,
} = useExportResponses();
const { totalItems, isLoadingData } = useInboxData();
const isEmpty = isLoadingData || totalItems === 0;

if ( ! userCanExport ) {
return null;
}

return (
<>
<Button size="compact" variant="primary" icon={ download } onClick={ openModal }>
<Button
size="compact"
variant="primary"
icon={ download }
onClick={ openModal }
accessibleWhenDisabled
disabled={ isEmpty }
label={ isEmpty ? __( 'Nothing to export.', 'jetpack-forms' ) : '' }
showTooltip={ isEmpty }
>
{ exportLabel }
</Button>

Expand Down
Loading