Jetpack Sync: Do not sync shop_order_placehold post-type

[coder-karen]

Part of SYNC-144

Proposed changes:

• This PR adds shop_order_placehold to the Jetpack sync post-type blacklist, as it does not need to be synced. See pf5801-1PW-p2

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pf5801-1PW-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

• Code-review.
• On a site with WooCommerce installed and active, on (Jetpack) trunk you can visit the Pc9OEs-v-p2 and you will not see shop_order_placehold in the 'Post type blacklist' (under 'Sync settings')
• With this PR applied via the Jetpack Beta tester plugin, you will see that post type listed in the above section.

To confirm the post type isn't synced:

• Add a new order draft, but don't click on 'create'. Add an item.
• In your sandbox, in wpsh, check to see that the post with shop_order_placehold has been added with gpr select * from wp_YOURBLOGID_posts where post_type="shop_order_placehold"
• Apply this PR, and follow the same steps. There should not be a entry in the cache site.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the add/sync-defaults-blacklist-shop_order_placehold branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/sync-defaults-blacklist-shop_order_placehold

bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/sync-defaults-blacklist-shop_order_placehold

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[jp-launch-control]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

[fgiannar]

LGTM