Skip to content

Conversation

@tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Nov 5, 2025

Closes MONOREP-182

This enables PHP 8.5 CI tests after a few tweaks for compatibility. In particular, changes are as follows:

  • Enabled PHP 8.5 + WP trunk. Once WP 6.9 is out we can switch to WP latest, but right now that just triggers tons of core deprecations.
  • Removed some unneeded Phan suppressions.
  • Updated docs.
  • Handle null offset deprecations by updating relevant monorepo code and disabling core deprecations.

Related PRs:

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Does CI show PHP 8.5 and is it happy?

@tbradsha tbradsha self-assigned this Nov 5, 2025
@tbradsha tbradsha added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Nov 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the add/php8.5/enable_ci_tests branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/php8.5/enable_ci_tests
bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/php8.5/enable_ci_tests

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Package] Patchwork Redefine Exit [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests Actions GitHub actions used to automate some of the work around releases and repository management Docs labels Nov 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: December 2, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@tbradsha tbradsha mentioned this pull request Nov 5, 2025
3 tasks
@jp-launch-control
Copy link

jp-launch-control bot commented Nov 5, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/sal/class.json-api-links.php 2/116 (1.72%) -0.01% 1 ❤️‍🩹

Full summary · PHP report · JS report

@tbradsha tbradsha force-pushed the add/php8.5/enable_ci_tests branch from c85d62d to ce0a74c Compare November 5, 2025 20:28
anomiex
anomiex previously approved these changes Nov 5, 2025
@tbradsha tbradsha merged commit 93ad698 into trunk Nov 6, 2025
124 of 125 checks passed
@tbradsha tbradsha deleted the add/php8.5/enable_ci_tests branch November 6, 2025 13:41
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants