-
Notifications
You must be signed in to change notification settings - Fork 839
wpcomsh: Trigger Jetpack sync on auto_update_plugins option change
#45636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for solving this @gcsecsey ! I have tested it, and it works as advertised. I was able to reproduce the issue using the production version of the wpcomsh plugin and then I was not able to reproduce it anymore after applying this branch. LGTM! ![]()
Before
CleanShot.2025-10-28.at.16.19.00.mp4
After
CleanShot.2025-10-28.at.17.11.58.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed it again after some Slack discussion p1762421903778689/1761317492.233479-slack-CDLH4C1UZ and I have identified an issue with this by following the following test steps:
- Ensure you have a WoW Dev blog with Jetpack Beta pointing to this branch
- Install a new plugin on the site, eg. https://wordpress.com/plugins/manage/sites/all-in-one-wp-migration
- After the plugin is installed, check that the Autoupdate toggle is enabled by default
Try to disable the auto-update toggle-> Refresh the page- The toggle changes to disable
This is the result when I am on the step 2 above, just after installing the plugin, refreshing the page:
Fixes DOTDEV-234
Related thread p1761317492233479-slack-CDLH4C1UZ
Proposed changes:
auto_update_pluginsoption is updated via thewpcomsh_auto_update_new_plugins_by_defaultfunctionOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
This issue only affects sites where auto updates haven't yet been set from the WP Admin side.
Setup:
Test the fix:
jetpack_autoupdate_pluginsoption is synced