fix(zerozone): add response size validation in RouterOut.handleRouter…#3261
Open
LukeSantossz wants to merge 2 commits intoAutoMQ:mainfrom
Open
fix(zerozone): add response size validation in RouterOut.handleRouter…#3261LukeSantossz wants to merge 2 commits intoAutoMQ:mainfrom
LukeSantossz wants to merge 2 commits intoAutoMQ:mainfrom
Conversation
…Response Add defensive validation to check if response count matches request count in handleRouterResponse. Previously, if the response list had fewer items than the request list, an IndexOutOfBoundsException would be thrown. Now the method: - Validates that responses.size() equals proxyRequests.size() - Logs an error with details when mismatch occurs - Gracefully completes all requests with UNKNOWN_SERVER_ERROR - Returns early to prevent the exception Also adds unit tests for ProxyRequest error handling behavior. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
LukeSantossz
requested review from
1sonofqiu,
Gezi-lzq,
superhx and
woshigaopp
as code owners
|
|
superhx
previously approved these changes
Mar 30, 2026
Collaborator
|
@LukeSantossz Hi, the CI check has failed. Could you please take a look and fix it. |
- Remove unused import CompletableFuture - Replace assertEquals(null, ...) with assertNull(...) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
Hey @superhx, I've sent a new commit that should fix the CI/CD tests — could you confirm it works? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleRouterResponseIndexOutOfBoundsExceptionwhen response size mismatchesUNKNOWN_SERVER_ERRORon mismatchProxyRequesterror handlingTest plan
RouterOutTest.java)