Skip to content

Fix issues with new nullability annotations #318

@ljacqu

Description

@ljacqu

This issue handles short-term issues that block a release; long-term issues will be handled in #319.

Issues:

  • Fix line length issues (check with CodeClimate)
  • Ensure that the build works locally again -> IntelliJ picks up its notnull annotation and adds bytecode that rejects null arguments
  • Property values are sometimes declared as notnull, sometimes as nullable (e.g. ConfigurationData#setValue is not-null, vs. #getValue is nullable... huh?). See also export values, BeanPropertyType allows null in toExportValue but it is not allowed in ListProperty
    • Not sure what the ideal thing is here, because BaseProperty impl. should never be null, and pretty much for all the use cases I envision for ConfigMe, property values aren't null. Maybe go all in and just declare them not-null everywhere? After all, Property<Optional<T>> is promoted for any cases where we want to skip having values.
  • PropertyBuilder#type is null for the inline array implementation. Adapt.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions