-
Notifications
You must be signed in to change notification settings - Fork 20
Fix issues with new nullability annotations #318
Copy link
Copy link
Closed
Milestone
Description
This issue handles short-term issues that block a release; long-term issues will be handled in #319.
Issues:
- Fix line length issues (check with CodeClimate)
- Ensure that the build works locally again -> IntelliJ picks up its notnull annotation and adds bytecode that rejects null arguments
- Property values are sometimes declared as notnull, sometimes as nullable (e.g. ConfigurationData#setValue is not-null, vs. #getValue is nullable... huh?). See also export values, BeanPropertyType allows null in
toExportValuebut it is not allowed in ListProperty- Not sure what the ideal thing is here, because BaseProperty impl. should never be null, and pretty much for all the use cases I envision for ConfigMe, property values aren't null. Maybe go all in and just declare them not-null everywhere? After all,
Property<Optional<T>>is promoted for any cases where we want to skip having values.
- Not sure what the ideal thing is here, because BaseProperty impl. should never be null, and pretty much for all the use cases I envision for ConfigMe, property values aren't null. Maybe go all in and just declare them not-null everywhere? After all,
- PropertyBuilder#type is null for the inline array implementation. Adapt.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels