Expose activity info #136
Merged
Expose activity info #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandroferraioli95
force-pushed
the
feature/add-flight-mode-info
branch
from
a0b3e4a to
dea4246
Compare
bkueng
reviewed
Aug 5, 2025
|
|
||
|
|
||
| void onFlightModeInfoChange(const std::function<void(const std::optional<std::string>&)> & callback) { _on_flight_mode_info_change = callback; } | ||
| void setFlightModeInfo(const std::optional<std::string>& flightModeInfo); |
Collaborator
There was a problem hiding this comment.
Can you avoid the term flight mode? It can also be used on non-flying vehicles. Maybe 'activity info' would be better.
Can you add API docs for what the purpose of this is? Are there formatting constraints (i.e. can it be multiple lines)?
Should the info be cleared when moving on to the next mission item? Or when deactivating and on abort?
alessandroferraioli95
force-pushed
the
feature/add-flight-mode-info
branch
from
dea4246 to
7e7a1e9
Compare
alessandroferraioli95
changed the title
alessandroferraioli95
force-pushed
the
feature/add-flight-mode-info
branch
from
7e7a1e9 to
feb34e8
Compare
bkueng
force-pushed
the
takeoff-to-altitude
branch
from
a5510df to
0b0de17
Compare
bkueng
force-pushed
the
feature/add-flight-mode-info
branch
from
feb34e8 to
998eca0
Compare
bkueng
reviewed
Aug 6, 2025
alessandroferraioli95
force-pushed
the
feature/add-flight-mode-info
branch
3 times, most recently
from
8cd3cb9 to
11d86e0
Compare
bkueng
reviewed
Aug 7, 2025
| /** | ||
| * @brief Clears the activity information. | ||
| * This method sets the activity info of the mission executor to `std::nullopt`. | ||
| * It should be called after an action is completed to ensure the state is properly reset. |
Collaborator
There was a problem hiding this comment.
Let's call this automatically when switching to the next waypoint, or when the mission is deactivated or aborted.
Collaborator
There was a problem hiding this comment.
I saw that. It's an extra step that can easily be forgotten.
alessandroferraioli95
force-pushed
the
feature/add-flight-mode-info
branch
from
11d86e0 to
37e0cf4
Compare
bkueng
approved these changes
Aug 7, 2025
alessandroferraioli95
changed the title
bkueng
force-pushed
the
takeoff-to-altitude
branch
from
f4afb3a to
644fb7e
Compare
bkueng
force-pushed
the
feature/add-flight-mode-info
branch
from
37e0cf4 to
030c980
Compare
eyeam3
force-pushed
the
takeoff-to-altitude
branch
from
644fb7e to
748b7c7
Compare
bkueng
force-pushed
the
takeoff-to-altitude
branch
2 times, most recently
from
986409f to
45eba72
Compare
bkueng
force-pushed
the
feature/add-flight-mode-info
branch
2 times, most recently
from
08a1785 to
b9d0f45
Compare
bkueng
force-pushed
the
takeoff-to-altitude
branch
3 times, most recently
from
ac68a06 to
e0f68dc
Compare
bkueng
force-pushed
the
feature/add-flight-mode-info
branch
from
b9d0f45 to
b44a064
Compare
We need a way from an action to set some extra information about the current activity, so those can gets exposed externally if wanted. This commit adds an interface from the ActionHandler to set/clear the activity info into the mission_executor. It will call the clear activty info when: - switch next waypoint - mission aborted - mission deactivated
bkueng
force-pushed
the
feature/add-flight-mode-info
branch
from
b44a064 to
98a3c14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a way from an action to set some extra information about the current action, so those can gets exposed externally if wanted.
This commit adds an interface from the ActionHandler to set/clear the flight mode info into the mission_execturo