Provide base class for dataset loaders#59
Merged
benedekrozemberczki merged 2 commits intoAstraZeneca:mainfrom Jan 21, 2022
Merged
Provide base class for dataset loaders#59benedekrozemberczki merged 2 commits intoAstraZeneca:mainfrom
benedekrozemberczki merged 2 commits intoAstraZeneca:mainfrom
Conversation
This will allow for the future addition of an eager dataset loader
benedekrozemberczki
approved these changes
Jan 21, 2022
Contributor
benedekrozemberczki
left a comment
There was a problem hiding this comment.
Looks great @cthoyt !
|
any chance we would load , train and essentially test our own dataset ? |
Contributor
Author
|
@aminemosbah I would suggest looking at https://chemicalx.readthedocs.io/en/latest/api/chemicalx.data.LocalDatasetLoader.html#chemicalx.data.LocalDatasetLoader for loading your own dataset that's already in the right format in a given directory |
|
thx, but i have smiles to predict in a csv file to predict locally , any quick snippet ? |
Contributor
Author
|
@aminemosbah I have in mind a solution for what you want (which is the obvious realistic use case) but this it is blocked #50 and #58. @benedekrozemberczki would love to get your input on #50 ;) |
|
need to hack the dataloader to make it work for local data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR abstracts the essential components of the dataset loader into a base class to allow for future implementations of eager datasets (e.g., all parts of the dataset are already in memory) and for other lazy local dataset loaders.
Changes
RemoteDatasetLoaderNext steps
The following shows an implementation of an eager dataset, which might be more useful for local datasets.