Clean up feature sets and labels flag#55
Merged
benedekrozemberczki merged 11 commits intoAstraZeneca:mainfrom Jan 19, 2022
Merged
Clean up feature sets and labels flag#55benedekrozemberczki merged 11 commits intoAstraZeneca:mainfrom
benedekrozemberczki merged 11 commits intoAstraZeneca:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #55 +/- ##
==========================================
- Coverage 97.83% 97.60% -0.23%
==========================================
Files 28 28
Lines 739 669 -70
==========================================
- Hits 723 653 -70
Misses 16 16
Continue to review full report at Codecov.
|
benedekrozemberczki
approved these changes
Jan 19, 2022
Contributor
|
Thank you @cthoyt looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the redundant re-definition of dictionary functions in the drug feature set and context feature set. It also removes the
labelflag, which is always true. This PR cleans up the LabeledTriples class to also be more contained. This PR finally also turns on MyPy checks.Changes
labelflag from all classes since it's always true