Skip to content

Update CI#44

Merged
benedekrozemberczki merged 3 commits intoAstraZeneca:mainfrom
cthoyt:update-ci
Jan 17, 2022
Merged

Update CI#44
benedekrozemberczki merged 3 commits intoAstraZeneca:mainfrom
cthoyt:update-ci

Conversation

@cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Jan 17, 2022

Summary

This PR refactors the CI code into three separate workflows for code QA, documentation, and testing.

  • Code passes all tests
  • Unit tests provided for these changes
  • Documentation and docstrings added for these changes

Changes

  • Split existing CI pipeline
  • Add pyroma metadata check
  • Add manifest check
  • Add missing author email to metadata to pass pyroma
  • Add declarative setup.cfg for more easy package metadata listing (can switch completely later)

@codecov-commenter
Copy link

Codecov Report

Merging #44 (c5d82cd) into main (53ca94b) will not change coverage.
The diff coverage is n/a.

❗ Current head c5d82cd differs from pull request most recent head 6bdb463. Consider uploading reports for the commit 6bdb463 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files          28       28           
  Lines         671      671           
=======================================
  Hits          662      662           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ca94b...6bdb463. Read the comment docs.

@benedekrozemberczki benedekrozemberczki merged commit 6ac8eb3 into AstraZeneca:main Jan 17, 2022
@benedekrozemberczki
Copy link
Contributor

This pyroma package looks interesting - does it check for code smells?

@cthoyt
Copy link
Contributor Author

cthoyt commented Jan 17, 2022

Nope, pyroma only checks for minimum packaging metadata (author name, author email, python version, license, etc.)

@cthoyt cthoyt deleted the update-ci branch January 17, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants