Update documentation build#38
Merged
benedekrozemberczki merged 6 commits intoAstraZeneca:mainfrom Jan 16, 2022
Merged
Conversation
This adds testing to make sure sphinx can build the docs properly (and also makes necessary updates)
cthoyt
commented
Jan 14, 2022
| html_logo = "_static/img/chemicalx.jpg" | ||
| html_static_path = ["_static"] | ||
| html_context = {"css_files": ["_static/css/custom.css"]} | ||
| # html_context = {"css_files": ["_static/css/custom.css"]} |
Contributor
Author
There was a problem hiding this comment.
this seemed to break the build locally but I guess it's working on RTD? I'd rather skip this since local testing is important
4 tasks
Contributor
|
This is amazing @cthoyt! The undeployed doc build checks were a pain before. Thank you for taking the time! |
benedekrozemberczki
approved these changes
Jan 16, 2022
Contributor
Author
|
This is definitely why it pays to have a project template that enforces this stuff from the beginning - it's a ton of busy work to get stuff back to working if you're not sure what broke it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds testing to make sure sphinx can build the docs properly (and also makes necessary updates)
Changes