Add base model and implement model class resolution#18
Merged
benedekrozemberczki merged 2 commits intoAstraZeneca:mainfrom Jan 12, 2022
Merged
Add base model and implement model class resolution#18benedekrozemberczki merged 2 commits intoAstraZeneca:mainfrom
benedekrozemberczki merged 2 commits intoAstraZeneca:mainfrom
Conversation
Contributor
|
Sorry @cthoyt could you pull again and I will merge! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a base model for all DDI models where we can keep shared code (it can later be subclassed based on the different tasks or to create meaningful abstractions between models that share concepts). It then uses the
class-resolverpackage for lookup of models, which is how we made thepipeline()function in PyKEEN that I think will go well in this package too.Changes