Integrate orml-xtokens into Shibuya#925
Closed
shaunxw wants to merge 8 commits intoAstarNetwork:masterfrom
Closed
Conversation
Contributor
Author
|
It seems no automatic checks are triggered, probably because I'm a first-time contributor. Can someone approve these checks to run? |
Contributor
Author
|
Replaced by #929 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Integrate
orml-xtokensinto Shibuya.Note that for XCM unit tests, I kept the original tests that using
pallet-xcmfork extra calls, to make sure that they still got covered before the fork is removed. These tests are renamed tox_via_pallet_xcm. The newly added tests are basically the same except for replacing fork extra calls withorml-xtokenscalls.Check list