Uplift to v1.5 by PierreOssun · Pull Request #1256 · AstarNetwork/Astar

PierreOssun · 2024-06-07T12:19:00Z

Uplift to v1.5

XCM: Use Message Queue as DMP and XCMP dispatch queue
Use Message Queue as DMP and XCMP dispatch queue #1246
Add Message Queue pallet & migration to remove DMP pallet+ Some changes to XCMP Queue pallet config

Contracts: Add XCM traits to interface with contracts
#2086
#1248
Removes contracts-primitives dep and replace it with uapi + Not activate XCM by setting to ()

Refactor ChainSpec
chain-spec: getting ready for native-runtime-free world #1256

Identity pallet changes
Identity pallet improvements #2048

StateBackend changes
sp-api: Move macro related re-exports to __private #2446
Move deps from sp_api to sc_client_api

Grandpa notification settings
Rework the event system of sc-network #1370

Also added:
pallet-xcm: enhance reserve_transfer_assets to support remote reserves #1672
pallet-xcm: add new flexible transfer_assets() call/extrinsic #2388

Astar owned repo updated:
Polkadot SDK
frontier
ORML

TODO:

fix CI
benchmark

ashutoshvarma · 2024-06-12T06:54:15Z

@PierreOssun once #1259 is merged, please merge master into your PR so we can have tests Ermal made?

…k-v1.5 # Conflicts: # Cargo.lock

ashutoshvarma

Looks good overall
initial review, will take a more closer look tomorrow

runtime/astar/src/lib.rs

runtime/astar/src/weights/pallet_xcm.rs

runtime/astar/src/xcm_config.rs

runtime/shibuya/src/lib.rs

Dinonard

I believe this migration is missing?
paritytech/polkadot-sdk#2142

Dinonard · 2024-06-12T14:48:07Z

@ashutoshvarma just to confirm - you will integrate this part?
paritytech/polkadot-sdk#4578

ashutoshvarma · 2024-06-12T14:54:31Z

@ashutoshvarma just to confirm - you will integrate this part? paritytech/polkadot-sdk#4578

@Dinonard Yes I'll

PierreOssun · 2024-06-13T14:04:14Z

/bench astar-dev,shibuya-dev,shiden-dev pallet_xcm

github-actions · 2024-06-13T14:37:50Z

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9501114705.
Please wait for a while.
Branch: uplift-sdk-v1.5
SHA: 3ba2283

github-actions · 2024-06-13T15:27:04Z

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/9501114705.

PierreOssun · 2024-06-14T10:19:52Z

/bench astar-dev,shibuya-dev,shiden-dev pallet_xcm

github-actions · 2024-06-14T11:34:38Z

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9514536999.
Please wait for a while.
Branch: uplift-sdk-v1.5
SHA: a459e1b

github-actions · 2024-06-14T12:27:11Z

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/9514536999.

PierreOssun · 2024-07-01T14:22:16Z

/bench astar-dev,shibuya-dev,shiden-dev pallet_xcm

github-actions · 2024-07-01T14:22:33Z

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9745988914.
Please wait for a while.
Branch: uplift-sdk-v1.5
SHA: a459e1b

github-actions · 2024-07-01T15:12:14Z

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/9745988914.

github-actions · 2024-07-05T15:02:36Z

Package	Line Rate	Branch Rate	Health
pallets/dapp-staking-v3/src/test	0%	0%	❌
chain-extensions/types/assets/src	0%	0%	❌
pallets/xvm/src	54%	0%	➖
pallets/oracle-benchmarks/src	0%	0%	❌
precompiles/unified-accounts/src	100%	0%	✔
precompiles/dapp-staking-v3/src/test	0%	0%	❌
precompiles/xvm/src	75%	0%	➖
pallets/dynamic-evm-base-fee/src	89%	0%	✔
chain-extensions/xvm/src	0%	0%	❌
pallets/ethereum-checked/src	79%	0%	➖
pallets/price-aggregator/src	72%	0%	➖
primitives/src/xcm	64%	0%	➖
chain-extensions/types/unified-accounts/src	0%	0%	❌
pallets/astar-xcm-benchmarks/src/generic	100%	0%	✔
pallets/dapp-staking-migration/src	0%	0%	❌
pallets/unified-accounts/src	86%	0%	✔
pallets/collator-selection/src	92%	0%	✔
precompiles/assets-erc20/src	81%	0%	✔
precompiles/dispatch-lockdrop/src	86%	0%	✔
primitives/src	62%	0%	➖
pallets/static-price-provider/src	52%	0%	➖
precompiles/sr25519/src	64%	0%	➖
pallets/dapp-staking-v3/src	90%	0%	✔
pallets/astar-xcm-benchmarks/src/fungible	100%	0%	✔
chain-extensions/types/xvm/src	0%	0%	❌
precompiles/xcm/src	73%	0%	➖
precompiles/dapp-staking-v3/src	90%	0%	✔
pallets/inflation/src	83%	0%	✔
chain-extensions/pallet-assets/src	56%	0%	➖
pallets/astar-xcm-benchmarks/src	88%	0%	✔
pallets/collective-proxy/src	86%	0%	✔
pallets/dapp-staking-v3/rpc/runtime-api/src	0%	0%	❌
pallets/dapp-staking-v3/src/benchmarking	98%	0%	✔
chain-extensions/unified-accounts/src	0%	0%	❌
precompiles/substrate-ecdsa/src	74%	0%	➖
pallets/xc-asset-config/src	64%	0%	➖
Summary	77% (3704 / 4796)	0% (0 / 0)	➖

Minimum allowed line rate is 50%

ermalkaleci · 2024-07-12T10:08:12Z

#1290 Contains missing changes

update Cargo deps to v1.5 and uplift Astar runtime

b5a5dd0

PierreOssun marked this pull request as draft June 7, 2024 12:19

PierreOssun changed the title ~~update Cargo deps to v1.5 and uplift Astar runtime~~ Uplift to v1.5 Jun 7, 2024

PierreOssun added 3 commits June 7, 2024 14:19

fmt

fd61ba4

uplift shiden and shibuya

57ea34e

uplift genesis config

2534768

PierreOssun added runtime This PR/Issue is related to the topic “runtime”. client This PR/Issue is related to the topic “client”. labels Jun 10, 2024

updated client

b0bce3e

PierreOssun added shiden related to shiden runtime astar Related to Astar shibuya related to shibuya labels Jun 10, 2024

PierreOssun added 10 commits June 10, 2024 12:03

updated lift tests

04556cc

fmt

49f57a5

fix try-runtime and runtime-benchmarks

24d00ed

fmt

ba64d45

clippy fix

0c5db26

Fixed integration tests

903c081

fix Cargo

1d386b3

fix Cargo

043d8d1

rollback fix Cargo

f892446

remove dep

05e5dee

PierreOssun marked this pull request as ready for review June 11, 2024 15:13

PierreOssun requested review from Dinonard, ashutoshvarma and ermalkaleci June 11, 2024 15:13

add rust-src to components

628a70d

PierreOssun added 2 commits June 12, 2024 10:36

fix try-runtime compilation

e3dee70

Merge branch 'master' of github.com:AstarNetwork/Astar into uplift-sd…

e2c797c

…k-v1.5 # Conflicts: # Cargo.lock

ashutoshvarma requested changes Jun 12, 2024

View reviewed changes

runtime/astar/src/lib.rs Outdated Show resolved Hide resolved

runtime/astar/src/weights/pallet_xcm.rs Show resolved Hide resolved

runtime/astar/src/xcm_config.rs Show resolved Hide resolved

runtime/shibuya/src/lib.rs Outdated Show resolved Hide resolved

Dinonard requested changes Jun 12, 2024

View reviewed changes

Pr comments

77f4444

PierreOssun added 2 commits June 13, 2024 09:40

fix Shiden try-runtime dep

56465c4

Added migration

3ba2283

PierreOssun requested review from Dinonard and ashutoshvarma June 14, 2024 08:12

PierreOssun added 2 commits June 14, 2024 10:13

updated weight

c86b63b

updated benchmark

a459e1b

PierreOssun self-assigned this Jul 2, 2024

ermalkaleci added 2 commits July 5, 2024 15:32

merge master & fix conflicts

d5c7de7

fmt

68b7155

ermalkaleci approved these changes Jul 12, 2024

View reviewed changes

Dinonard approved these changes Jul 12, 2024

View reviewed changes

ashutoshvarma approved these changes Jul 12, 2024

View reviewed changes

ermalkaleci merged commit 7596fdc into master Jul 12, 2024

ermalkaleci deleted the uplift-sdk-v1.5 branch July 12, 2024 10:10

Conversation

PierreOssun commented Jun 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashutoshvarma commented Jun 12, 2024

Uh oh!

ashutoshvarma left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dinonard left a comment

Choose a reason for hiding this comment

Uh oh!

Dinonard commented Jun 12, 2024

Uh oh!

ashutoshvarma commented Jun 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PierreOssun commented Jun 13, 2024

Uh oh!

github-actions bot commented Jun 13, 2024

Uh oh!

github-actions bot commented Jun 13, 2024

Uh oh!

PierreOssun commented Jun 14, 2024

Uh oh!

github-actions bot commented Jun 14, 2024

Uh oh!

github-actions bot commented Jun 14, 2024

Uh oh!

PierreOssun commented Jul 1, 2024

Uh oh!

github-actions bot commented Jul 1, 2024

Uh oh!

github-actions bot commented Jul 1, 2024

Uh oh!

github-actions bot commented Jul 5, 2024

Uh oh!

ermalkaleci commented Jul 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PierreOssun commented Jun 7, 2024 •

edited

Loading

ashutoshvarma commented Jun 12, 2024 •

edited

Loading