Skip to content

Clarify the postgres instructions for setting NOT NULL on an existing column to prevent an ACCESS EXCLUSIVE lock #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrew-lewin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clarify the postgres instructions for setting NOT NULL on an existing column to prevent an ACCESS EXCLUSIVE lock #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,9 +555,7 @@ If you're using Postgres 12+, you can add the NOT NULL to the column after valid
def change do
execute "ALTER TABLE recipes VALIDATE CONSTRAINT favourite_not_null", ""

alter table("recipes") do
modify :favourite, :boolean, null: false
end
execute "ALTER TABLE recipes ALTER COLUMN favourite SET NOT NULL", "ALTER TABLE recipes ALTER COLUMN favourite DROP NOT NULL"

drop constraint("recipes", :favourite_not_null)
end
Expand Down