pdf_choice_widget_options2: avoid core dump with _GLIBCXX_ASSERTIONS#55
Open
mjg wants to merge 1 commit intoArtifexSoftware:masterfrom
Open
pdf_choice_widget_options2: avoid core dump with _GLIBCXX_ASSERTIONS#55mjg wants to merge 1 commit intoArtifexSoftware:masterfrom
mjg wants to merge 1 commit intoArtifexSoftware:masterfrom
Conversation
From a C programmer's view, &opts[0] == opts, but for the vector class in stdc++ there is a difference in if, where and when the existence of a zeroth element is checked. This matters for "empty" vectors only, but depending on g++/stdc++ version and flags this may throw an unexpected assertion and abort on run time. Noticed with gcc 15 on Fedora rawhide (42). Replace &opts[0] by opts.data() which gives the pointer to the data storage of the vector, which is what pdf_choice_widget_options expects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a C programmer's view, &opts[0] == opts, but for the vector class in stdc++ there is a difference in if, where and when the existence of a zeroth element is checked. This matters for "empty" vectors only, but depending on g++/stdc++ version and flags this may throw an unexpected assertion and abort on run time. Noticed with gcc 15 on Fedora rawhide (42).
Replace &opts[0] by opts.data() which gives the pointer to the data storage of the vector, which is what pdf_choice_widget_options expects.