feat!: langchainjs 1.0 #2444

mikeldking · 2025-11-13T21:26:47Z

resolves #2430

cursor

Bug: Module Path Mismatch Breaks Test Mocks

The vi.mock("@langchain/openai") targets the wrong module path. The test imports ChatOpenAI and OpenAIEmbeddings from @langchain/openaiV0.3 (line 31), but the mock is registered for @langchain/openai. This causes the mock to not apply, meaning tests will use the real implementation instead of the mocked one, breaking the test setup and potentially causing test failures or unexpected behavior.

js/packages/openinference-instrumentation-langchain/test/langchainV3.test.ts#L67-L68

openinference/js/packages/openinference-instrumentation-langchain/test/langchainV3.test.ts

Lines 67 to 68 in 5308863


	vi.mock("@langchain/openai", async () => {

js/packages/openinference-instrumentation-langchain/test/langchainV3.test.ts

js/packages/openinference-instrumentation-langchain/tsconfig.json

js/packages/openinference-instrumentation-langchain/test/tracer.test.ts

pkg-pr-new · 2025-11-14T05:15:06Z

Open in StackBlitz

@arizeai/openinference-core

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-core@2444

@arizeai/openinference-genai

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-genai@2444

@arizeai/openinference-instrumentation-anthropic

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-anthropic@2444

@arizeai/openinference-instrumentation-bedrock

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-bedrock@2444

@arizeai/openinference-instrumentation-bedrock-agent-runtime

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-bedrock-agent-runtime@2444

@arizeai/openinference-instrumentation-beeai

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-beeai@2444

@arizeai/openinference-instrumentation-langchain

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-langchain@2444

@arizeai/openinference-instrumentation-langchain-v0

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-langchain-v0@2444

@arizeai/openinference-instrumentation-mcp

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-mcp@2444

@arizeai/openinference-instrumentation-openai

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-openai@2444

@arizeai/openinference-mastra

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-mastra@2444

@arizeai/openinference-semantic-conventions

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-semantic-conventions@2444

@arizeai/openinference-vercel

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-vercel@2444

commit: df8b058

cephalization

Nice, the agent example looks good to me when I run it myself. Not sure how non-agent use cases work but I assume the agent uses normal langchain calls under the hood

cephalization · 2025-11-14T13:00:37Z

js/packages/openinference-instrumentation-langchain/tsconfig.esnext.json

 {
  "extends": "../../tsconfig.base.esnext.json",
  "compilerOptions": {
    "outDir": "dist/esnext",


I don't actually think that esnext is an accessible dist location. I think we can nuke the build step for esnext. commonjs apps will access the commonjs dist, and esm apps access the esm dist. I don't know which runtimes actually access the esnext dist. We can shrink the package size by quite a bit by dropping esnext builds

cursor · 2025-11-14T15:50:03Z

js/packages/openinference-instrumentation-langchain/examples/agent.ts

+  const agent = createAgent({
+    model: "gpt-4o-mini", // Using a more accessible model
+    tools: [getWeather, calculateMath, searchInfo],
+  });


Bug: Type mismatch: createAgent model parameter.

The createAgent function is called with model: "gpt-4o-mini" as a string parameter, but based on LangChain.js 1.0 documentation, createAgent expects an instantiated model object (like ChatOpenAI), not a model name string. This will cause a runtime error when the agent attempts to use the model for inference.

js/packages/openinference-instrumentation-langchain/package.json

cursor

Bug: Metadata Tests: Fix Convention Drift

The METADATA import was removed from @arizeai/openinference-semantic-conventions but the tests still reference metadata as a hardcoded string literal (e.g., metadata: "{}") in multiple assertions. This creates inconsistency with the semantic conventions pattern used elsewhere and makes the code more fragile if the metadata key name ever changes in the semantic conventions package.

js/packages/openinference-instrumentation-langchain/test/tracer.test.ts#L6-L7

openinference/js/packages/openinference-instrumentation-langchain/test/tracer.test.ts

Lines 6 to 7 in df8b058

    
           import { 
        
             MESSAGE_FUNCTION_CALL_NAME,

cursor · 2025-11-14T16:12:00Z

js/packages/openinference-instrumentation-langchain/examples/reasoning.ts

    openAIApiKey: process.env.OPENAI_API_KEY,
    modelName: "o3-mini",
-    reasoningEffort: "medium",
+    reasoning: { effort: "medium" },


Bug: ChatOpenAI API Key Parameter Inconsistency

The ChatOpenAI constructor still uses openAIApiKey parameter while the rest of the codebase (including all test files in this PR) was updated to use apiKey for @langchain/openai version 1.1.0. This inconsistency suggests the example wasn't fully migrated and may fail if openAIApiKey was deprecated in favor of apiKey in the newer version.

mikeldking requested a review from a team as a code owner November 13, 2025 21:26

github-project-automation bot added this to Instrumentation Nov 13, 2025

dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 13, 2025

cursor bot reviewed Nov 13, 2025

View reviewed changes

js/packages/openinference-instrumentation-langchain/test/langchainV3.test.ts Outdated Show resolved Hide resolved

mikeldking force-pushed the langchain-1 branch from 5308863 to 7434f2a Compare November 13, 2025 22:46

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 13, 2025

cursor bot reviewed Nov 13, 2025

View reviewed changes

js/packages/openinference-instrumentation-langchain/tsconfig.json Outdated Show resolved Hide resolved

dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Nov 13, 2025

cursor bot reviewed Nov 13, 2025

View reviewed changes

js/packages/openinference-instrumentation-langchain/test/tracer.test.ts Outdated Show resolved Hide resolved

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 14, 2025

cursor bot reviewed Nov 14, 2025

View reviewed changes

js/packages/openinference-instrumentation-langchain/test/tracer.test.ts Outdated Show resolved Hide resolved

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 14, 2025

mikeldking changed the title ~~feat: langchainjs 1.0~~ feat!: langchainjs 1.0 Nov 14, 2025

cephalization approved these changes Nov 14, 2025

View reviewed changes

mikeldking added 11 commits November 14, 2025 08:35

WIP

08fb729

cleanup

0689275

initial types

708704b

cleanup

b5a3239

make tests pass

b76e811

cleanup

399126f

add nock

871dc98

add node next

807e9d9

cleanup

0abde6c

cleanup

82728ee

cleanup

bc2b1ba

mikeldking added 8 commits November 14, 2025 08:35

cleanup build

3fc91cb

cleanup

9299e15

set param

8c227d5

cleanup

650da5e

cleanup

bb2ff68

changeset

9c63ca5

langraph example

ae59812

langraph

ff4be73

mikeldking force-pushed the langchain-1 branch from aa708e5 to ff4be73 Compare November 14, 2025 15:41

lock file

9b8426d

cursor bot reviewed Nov 14, 2025

View reviewed changes

lock file

7af1a20

cursor bot reviewed Nov 14, 2025

View reviewed changes

js/packages/openinference-instrumentation-langchain/package.json Outdated Show resolved Hide resolved

relax the peer deps

df8b058

cursor bot reviewed Nov 14, 2025

View reviewed changes

mikeldking merged commit 3ef46a9 into main Nov 14, 2025
8 checks passed

mikeldking deleted the langchain-1 branch November 14, 2025 16:13

github-project-automation bot moved this to Done in Instrumentation Nov 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat!: langchainjs 1.0 #2444

feat!: langchainjs 1.0 #2444

mikeldking commented Nov 13, 2025 •

edited

Loading

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new bot commented Nov 14, 2025 •

edited

Loading

Uh oh!

cephalization left a comment

Uh oh!

cephalization Nov 14, 2025

Uh oh!

cursor bot Nov 14, 2025

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

cursor bot Nov 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat!: langchainjs 1.0 #2444

feat!: langchainjs 1.0 #2444

Conversation

mikeldking commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Module Path Mismatch Breaks Test Mocks

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new bot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cephalization left a comment

Choose a reason for hiding this comment

Uh oh!

cephalization Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

cursor bot Nov 14, 2025

Choose a reason for hiding this comment

Bug: Type mismatch: createAgent model parameter.

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Metadata Tests: Fix Convention Drift

Uh oh!

cursor bot Nov 14, 2025

Choose a reason for hiding this comment

Bug: ChatOpenAI API Key Parameter Inconsistency

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mikeldking commented Nov 13, 2025 •

edited

Loading

pkg-pr-new bot commented Nov 14, 2025 •

edited

Loading

Bug: Type mismatch: `createAgent` model parameter.